Add CQP options to screen recorder hardware encoders #7967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like these options are not as platform-agnostic as I thought, I'll need to do more testing on different hardware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added options to use CQP instead of a set bitrate to the hardware encoders, in the same way that CRF is implemented for x264 and x265. I've only tested this with AMF, but from my research these options seem to be platform-agnostic.
I wasn't fully sure if I should enable it by default since it is a (mildly) breaking change, but I ended up doing it because I was going for "feature parity" with the software encoders. If I should change this, please let me know.