Replace SqlDataType AST type with DbDataType in mapping schema #4836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaceWindu
requested review from
igor-tkachev,
sdanyliv,
viceroypenguin,
jods4 and
Shane32
as code owners
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Source/LinqToDB.Scaffold/CodeModel/AST/Basics/AttributeOwner.cs
Outdated
Show resolved
Hide resolved
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
- remove unnecessary DataOptions parameter from ILinqToDBForEFTools EFCore interface
MaceWindu
force-pushed
the
refactoring/remove-ast-type-from-mapping-schema
branch
from
baf8bac to
8eb5f49
Compare
viceroypenguin
previously approved these changes
Feb 18, 2025
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
|
This will not make it into v6 due to amount of work required around types. Better to shift it to v7 alongside with planned type mapping refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlDataTypefrom mapping schema, useDbDataTypeDataOptionsparameter from EFC ILinqToDBForEFTools interface methodsIn progress/different PR:
remove (obsolete till v7) magic type tables and APIs inwill be done in separate PR due to complexitySqlDataType, types should be configured only inMappingSchema