I just noticed that one step is missing: we have to replace MMLbase::getEmpty. This is only called for MMLmspace or MMLmrow and returns the empty Element <mspace\>. With our current implementation, we get the full tag just without an inner text: <mspace><\mspace>. Either we change the tests, or we change MMLDomVisitor::getHTML from $this->dom->saveHTML( $this->dom->documentElement ) to $this->dom->saveXML( $this->dom->documentElement, LIBXML_NOEMPTYTAG ).

Wed, May 21, 2:10 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Mon, May 19

cscott added a comment to T393922: Make Parsoid/Zest/Remex safe for use with PHP8.4 Dom\Document.

The goal here is to move to the more standards-compliant PHP8.4 implementations as soon as WMF production is ready for them. We intend to switch to the PHP8.4 DOM classes in CI right away (https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/704745), so we don't regress.

Mon, May 19, 8:41 PM · Patch-For-Review, Parsoid-Read-Views (Performance and Cache research Q4 FY24-25), Parsoid, RemexHtml

Sun, May 18

ReleaseTaggerBot added a project to T389712: Make MMLbase support trees: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).

Sun, May 18, 8:00 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1143973 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace MMLleaf::encapsulateRaw nodes with __toString in BaseMethods.php

https://gerrit.wikimedia.org/r/1143973

Sun, May 18, 7:16 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Tue, May 13

gerritbot added a comment to T393922: Make Parsoid/Zest/Remex safe for use with PHP8.4 Dom\Document.

Change #704745 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Support Dodo/PHP8.4 DOM implementations

https://gerrit.wikimedia.org/r/704745

Tue, May 13, 10:39 PM · Patch-For-Review, Parsoid-Read-Views (Performance and Cache research Q4 FY24-25), Parsoid, RemexHtml

gerritbot added a project to T393922: Make Parsoid/Zest/Remex safe for use with PHP8.4 Dom\Document: Patch-For-Review.

Tue, May 13, 10:07 PM · Patch-For-Review, Parsoid-Read-Views (Performance and Cache research Q4 FY24-25), Parsoid, RemexHtml

gerritbot added a comment to T393922: Make Parsoid/Zest/Remex safe for use with PHP8.4 Dom\Document.

Change #1145340 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/libs/RemexHtml@master] Improve PHP 8.4 compatibility fixes

https://gerrit.wikimedia.org/r/1145340

Tue, May 13, 10:06 PM · Patch-For-Review, Parsoid-Read-Views (Performance and Cache research Q4 FY24-25), Parsoid, RemexHtml

Mon, May 12

cscott claimed T393922: Make Parsoid/Zest/Remex safe for use with PHP8.4 Dom\Document.

Mon, May 12, 3:50 PM · Patch-For-Review, Parsoid-Read-Views (Performance and Cache research Q4 FY24-25), Parsoid, RemexHtml

gerritbot added a comment to T324408: PHP Warning: Wikimedia\RemexHtml\DOM\DOMBuilder::createNode(): unterminated entity reference.

Change #1140271 merged by jenkins-bot:

[mediawiki/libs/RemexHtml@master] Fixes for PHP 8.4 Dom\Document compatibility

https://gerrit.wikimedia.org/r/1140271

Mon, May 12, 5:28 AM · MediaWiki-Platform-Team, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), RemexHtml, Patch-For-Review, Performance-Team (Radar), Design-System-Team, Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments, MediaWiki-ResourceLoader, Wikimedia-production-error

Sun, May 11

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1143973 had a related patch set uploaded (by FrederikHennecke1; author: FrederikHennecke1):

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.c Replace usages for encapsulateRaw when called on MMLleaf nodes with __toString for leaf nodes. Changes in BaseMethods.php

https://gerrit.wikimedia.org/r/1143973

Sun, May 11, 9:31 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

May 8 2025

Physikerwelt triaged T389712: Make MMLbase support trees as Medium priority.

May 8 2025, 8:02 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Physikerwelt added a comment to T389712: Make MMLbase support trees.

The $element->nodeValue code gives me an Error: "unterminated entity reference".

May 8 2025, 7:41 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

May 7 2025

FrederikHennecke1 added a comment to T389712: Make MMLbase support trees.

For Task 4.c, I have the following points:

Keep

if ( $node instanceof MMLleaf ) {
	$textNode = $this->dom->createTextNode( $node->getText() );
	$element->appendChild( $textNode );
	return;
}

instead of

May 7 2025, 10:32 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

May 4 2025

Physikerwelt updated the task description for T389712: Make MMLbase support trees.

May 4 2025, 8:15 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1141059 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.b, remove encapsulate method and tests

https://gerrit.wikimedia.org/r/1141059

May 4 2025, 7:55 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1137431 abandoned by Physikerwelt:

[mediawiki/extensions/Math@master] WIP: DOM performance test physikerwelt

Reason:

just performance test

https://gerrit.wikimedia.org/r/1137431

May 4 2025, 7:38 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

May 3 2025

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1141059 had a related patch set uploaded (by FrederikHennecke1; author: FrederikHennecke1):

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.b, remove encapsulate method and tests

https://gerrit.wikimedia.org/r/1141059

May 3 2025, 11:10 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Physikerwelt updated the task description for T389712: Make MMLbase support trees.

May 3 2025, 7:02 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Physikerwelt updated the task description for T389712: Make MMLbase support trees.

May 3 2025, 5:55 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Physikerwelt updated the task description for T389712: Make MMLbase support trees.

May 3 2025, 5:07 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Physikerwelt updated the task description for T389712: Make MMLbase support trees.

May 3 2025, 5:00 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1140793 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.b, fix for MMLmerror

https://gerrit.wikimedia.org/r/1140793

May 3 2025, 4:31 AM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

May 2 2025

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1140793 had a related patch set uploaded (by FrederikHennecke1; author: FrederikHennecke1):

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.b, fix for MMLmerror

https://gerrit.wikimedia.org/r/1140793

May 2 2025, 10:08 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

ReleaseTaggerBot edited projects for T389712: Make MMLbase support trees, added: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).

May 2 2025, 10:00 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1140532 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.b Replace usages for encapsulate with __toString

https://gerrit.wikimedia.org/r/1140532

May 2 2025, 9:54 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

May 1 2025

gerritbot added a comment to T389712: Make MMLbase support trees.

Change #1140532 had a related patch set uploaded (by FrederikHennecke1; author: FrederikHennecke1):

[mediawiki/extensions/Math@master] Make MMLbase support trees: Step 4.b Replace usages for encapsulate with __toString

https://gerrit.wikimedia.org/r/1140532

May 1 2025, 8:01 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), Patch-For-Review, RemexHtml, Math

Restricted Application added a project to T324408: PHP Warning: Wikimedia\RemexHtml\DOM\DOMBuilder::createNode(): unterminated entity reference: MediaWiki-Platform-Team.

Change #1140271 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/libs/RemexHtml@master] Fixes for PHP 8.4 Dom\Document compatibility

https://gerrit.wikimedia.org/r/1140271

May 1 2025, 5:22 AM · MediaWiki-Platform-Team, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), RemexHtml, Patch-For-Review, Performance-Team (Radar), Design-System-Team, Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments, MediaWiki-ResourceLoader, Wikimedia-production-error

Apr 29 2025

Bugreporter merged T392943: Using indentation markers together with HTML table tags can result in incorrect parsing outcomes. into T11996: Multiline HTML elements in lists parsed to broken HTML.

Apr 29 2025, 6:33 PM · Parsoid, RemexHtml, Tidy, MediaWiki-Parser

RemexHtmlComponentActivePublicWatch Project

Members (5)

Watchers (2)

Details

Recent ActivityView All

Sun, Jun 8

Sat, Jun 7

Fri, Jun 6

Wed, Jun 4

Fri, May 30

Thu, May 29

Sat, May 24

Fri, May 23

Thu, May 22

Wed, May 21

Mon, May 19

Sun, May 18

Tue, May 13

Mon, May 12

Sun, May 11

May 8 2025

May 7 2025

May 4 2025

May 3 2025

May 2 2025

May 1 2025

Apr 29 2025

RemexHtmlComponent
ActivePublic
Watch Project

Recent Activity
View All