Skip to content

Commit f6f20d9

Browse files
GreatSnoopymanolama
authored andcommitted
ISSUE-1344 Fix NPE when null is given as datapoint in a set (#1347)
Signed-off-by: clarsen <[email protected]>
1 parent 14e74b7 commit f6f20d9

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/tsd/PutDataPointRpc.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,14 @@ public String toString() {
170170
}
171171

172172
try {
173+
if (dp == null) {
174+
if (show_details) {
175+
details.add(this.getHttpDetails("Unexpected null datapoint encountered in set.", dp));
176+
}
177+
LOG.warn("Datapoint null was encountered in set.");
178+
illegal_arguments.incrementAndGet();
179+
continue;
180+
}
173181
if (dp.getMetric() == null || dp.getMetric().isEmpty()) {
174182
if (show_details) {
175183
details.add(this.getHttpDetails("Metric name was empty", dp));

0 commit comments

Comments
 (0)