Skip to content

Commit b72df48

Browse files
committed
Fix elide-model-config build warnings
1 parent c30dd75 commit b72df48

File tree

5 files changed

+20
-10
lines changed

5 files changed

+20
-10
lines changed

elide-model-config/src/main/java/com/yahoo/elide/modelconfig/model/Argument.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public class Argument implements Named {
4848

4949
@JsonProperty("values")
5050
@JsonDeserialize(as = LinkedHashSet.class)
51+
@Builder.Default
5152
private Set<String> values = new LinkedHashSet<>();
5253

5354
@JsonProperty("tableSource")

elide-model-config/src/main/java/com/yahoo/elide/modelconfig/model/Dimension.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import lombok.Data;
1515
import lombok.EqualsAndHashCode;
1616
import lombok.NoArgsConstructor;
17-
import lombok.Singular;
1817

1918
import java.util.ArrayList;
2019
import java.util.LinkedHashSet;
@@ -62,9 +61,11 @@ public class Dimension implements Named {
6261
private String category;
6362

6463
@JsonProperty("hidden")
64+
@Builder.Default
6565
private Boolean hidden = false;
6666

6767
@JsonProperty("readAccess")
68+
@Builder.Default
6869
private String readAccess = "Prefab.Role.All";
6970

7071
@JsonProperty("definition")
@@ -77,19 +78,21 @@ public class Dimension implements Named {
7778
private Type type;
7879

7980
@JsonProperty("grains")
80-
@Singular
81+
@Builder.Default
8182
private List<Grain> grains = new ArrayList<>();
8283

8384
@JsonProperty("tags")
8485
@JsonDeserialize(as = LinkedHashSet.class)
86+
@Builder.Default
8587
private Set<String> tags = new LinkedHashSet<>();
8688

8789
@JsonProperty("arguments")
88-
@Singular
90+
@Builder.Default
8991
private List<Argument> arguments = new ArrayList<>();
9092

9193
@JsonProperty("values")
9294
@JsonDeserialize(as = LinkedHashSet.class)
95+
@Builder.Default
9396
private Set<String> values = new LinkedHashSet<>();
9497

9598
@JsonProperty("tableSource")

elide-model-config/src/main/java/com/yahoo/elide/modelconfig/model/Join.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public class Join implements Named {
4343
private Join.Type type;
4444

4545
@JsonProperty("kind")
46+
@Builder.Default
4647
private Join.Kind kind = Join.Kind.TOONE;
4748

4849
@JsonProperty("definition")

elide-model-config/src/main/java/com/yahoo/elide/modelconfig/model/Measure.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import lombok.Data;
1515
import lombok.EqualsAndHashCode;
1616
import lombok.NoArgsConstructor;
17-
import lombok.Singular;
1817

1918
import java.util.ArrayList;
2019
import java.util.LinkedHashSet;
@@ -58,9 +57,11 @@ public class Measure implements Named {
5857
private String category;
5958

6059
@JsonProperty("hidden")
60+
@Builder.Default
6161
private Boolean hidden = false;
6262

6363
@JsonProperty("readAccess")
64+
@Builder.Default
6465
private String readAccess = "Prefab.Role.All";
6566

6667
@JsonProperty("definition")
@@ -74,10 +75,11 @@ public class Measure implements Named {
7475

7576
@JsonProperty("tags")
7677
@JsonDeserialize(as = LinkedHashSet.class)
78+
@Builder.Default
7779
private Set<String> tags = new LinkedHashSet<>();
7880

7981
@JsonProperty("arguments")
80-
@Singular
82+
@Builder.Default
8183
private List<Argument> arguments = new ArrayList<>();
8284

8385
/**

elide-model-config/src/main/java/com/yahoo/elide/modelconfig/model/Table.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import lombok.Data;
1818
import lombok.EqualsAndHashCode;
1919
import lombok.NoArgsConstructor;
20-
import lombok.Singular;
2120

2221
import java.util.ArrayList;
2322
import java.util.LinkedHashSet;
@@ -68,9 +67,11 @@ public class Table implements Named {
6867
private String dbConnectionName;
6968

7069
@JsonProperty("isFact")
70+
@Builder.Default
7171
private Boolean isFact = true;
7272

7373
@JsonProperty("hidden")
74+
@Builder.Default
7475
private Boolean hidden = false;
7576

7677
@JsonProperty("description")
@@ -86,26 +87,28 @@ public class Table implements Named {
8687
private String cardinality;
8788

8889
@JsonProperty("readAccess")
90+
@Builder.Default
8991
private String readAccess = "Prefab.Role.All";
9092

9193
@JsonProperty("joins")
92-
@Singular
94+
@Builder.Default
9395
private List<Join> joins = new ArrayList<>();
9496

9597
@JsonProperty("measures")
96-
@Singular
98+
@Builder.Default
9799
private List<Measure> measures = new ArrayList<>();
98100

99101
@JsonProperty("dimensions")
100-
@Singular
102+
@Builder.Default
101103
private List<Dimension> dimensions = new ArrayList<>();
102104

103105
@JsonProperty("tags")
104106
@JsonDeserialize(as = LinkedHashSet.class)
107+
@Builder.Default
105108
private Set<String> tags = new LinkedHashSet<>();
106109

107110
@JsonProperty("arguments")
108-
@Singular
111+
@Builder.Default
109112
private List<Argument> arguments = new ArrayList<>();
110113

111114
@JsonProperty("extend")

0 commit comments

Comments
 (0)