Skip to content

[google_maps_flutter_ios] Fails xcodebuild analyze on macOS 26 #170354

Closed
flutter/packages
#9415
@vashworth

Description

@vashworth

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20ios_platform_tests_shard_2%20master/22179/overview

/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:439:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  439 |   if (compassEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~
  440 |     [self setCompassEnabled:compassEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  441 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:443:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  443 |   if (indoorEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~
  444 |     [self setIndoorEnabled:indoorEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  445 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:447:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  447 |   if (trafficEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~
  448 |     [self setTrafficEnabled:trafficEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  449 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:451:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  451 |   if (buildingsEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~
  452 |     [self setBuildingsEnabled:buildingsEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  453 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:460:21: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  460 |     float minZoom = zoomData.min ? zoomData.min.floatValue : kGMSMinZoomLevel;
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:461:21: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  461 |     float maxZoom = zoomData.max ? zoomData.max.floatValue : kGMSMaxZoomLevel;
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:470:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  470 |   if (rotateGesturesEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~~~~~
  471 |     [self setRotateGesturesEnabled:rotateGesturesEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  472 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:474:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  474 |   if (scrollGesturesEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~~~~~
  475 |     [self setScrollGesturesEnabled:scrollGesturesEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  476 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:478:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  478 |   if (tiltGesturesEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~~~
  479 |     [self setTiltGesturesEnabled:tiltGesturesEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  480 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:482:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  482 |   if (trackCameraPosition) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~~~
  483 |     [self setTrackCameraPosition:trackCameraPosition.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  484 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:486:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  486 |   if (zoomGesturesEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~~~
  487 |     [self setZoomGesturesEnabled:zoomGesturesEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  488 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:490:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  490 |   if (myLocationEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~
  491 |     [self setMyLocationEnabled:myLocationEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  492 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:494:7: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  494 |   if (myLocationButtonEnabled) {
      |   ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
  495 |     [self setMyLocationButtonEnabled:myLocationButtonEnabled.boolValue];
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  496 |   }
      |   ~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m:668:42: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  668 |   FGMCATransactionWrapper *transaction = durationMilliseconds ? self.transactionWrapper : nil;
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
14 warnings generated.
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:130:3: warning: nil returned from a function that is expected to return a non-null value [nullability.NullReturnedFromNonnull]
  130 |   return image;
      |   ^~~~~~~~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:194:8: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  194 |   if (!width && !height) {
      |       ~^~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:194:18: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  194 |   if (!width && !height) {
      |                 ~^~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:198:25: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  198 |   CGFloat targetWidth = width ? width.doubleValue : image.size.width;
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:199:26: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  199 |   CGFloat targetHeight = height ? height.doubleValue : image.size.height;
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:201:17: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  201 |   if (width && !height) {
      |                ~^~~~~~
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMImageUtils.m:205:15: warning: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue [osx.NumberObjectConversion]
  205 |   } else if (!width && height) {
      |              ~^~~~~
7 warnings generated.

Metadata

Metadata

Labels

p: mapsGoogle Maps pluginpackageflutter/packages repository. See also p: labels.platform-iosiOS applications specificallyteam-iosOwned by iOS platform team

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions