Skip to content

Misleading diagnostic during constructor eval #16

Open
@autarch

Description

@autarch

Migrated from rt.cpan.org #98588 (status was 'stalled')

Requestors:

From [email protected] on 2014-09-03 15:02:22:

I noticed this when I missed one of the dependencies (List::AllUtils) that was added in v1.71, at which point all attempts to create a DateTime::TimeZone object failed with this message:

'Cannot determine local time zone'

Turns out this message is seriously misleading.

Tracing through the debugger, I came across this eval, which in v1.74 is located at line 74 of lib/DateTime/TimeZone.pm:

    my $e = do {
        local $@;
        local $SIG{__DIE__};
        eval "require $real_class";
        $@;
    };

If the class being require'ed isn't available, you should get the actual message returned, like so:

Can't locate List::AllUtils in @inc ...

But you don't. Fixing this would probably eliminate a lot of confusing bug reports against this module.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions