Skip to content

Spaceship breaks nested tables in very specific circumstance. #97

Open
@vincerubinetti

Description

@vincerubinetti

Here's the code that causes the issue:

<table>
  <tr>
    <td>test</td>
    <td>test</td>
  </tr>
  <tr>
    <td>test</td>
    <td>
      <span>test</span>

      <table>
        <tr>
          <td>test</td>
          <td>test</td>
          <td>test</td>
        </tr>
      </table>
    </td>
  </tr>
</table>

The result:

Screenshot 2024-03-25 at 5 47 22 PM

If I wrap the nested <span> and <table> in a single <div>, it works as expected:

Screenshot 2024-03-25 at 5 48 51 PM

Initially I thought this must've been an issue with Jekyll's markdown parsers. See these issues for more information and more cases of odd/wrong behavior:

gettalong/kramdown#803
kramdown/parser-gfm#39

But then I tested those gems directly, and they didn't produce the problems. Eventually I narrowed down the problem to just jekyll-spaceship. If I have it on, this breaks.

Here's a minimal reproducible example. If you comment out the spaceship plugin in the gemfile, it works.

minimal-reproduction.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions