Skip to content

Searching for a proper way of differentiating Asustor AS66xx and AS53xx #38

Open
@Tki2000

Description

@Tki2000

Currently now, the Asustor code for matching AS66xx conflicts with an AS5304T. They return the same DMI info strings, but the gpios do not seem to be defined the same.

I don't own any AS66xx device so I cannot tell if the AS66xx is properly handled in this code repository, but it is not correct for driving the leds on an AS5304T.

I have not found a proper way of telling the two models apart. Tried with an UUID string but I think it is not working properly and found that UUID is common on other generic devices, so for my needs I have just overridden the AS66xx detection and redirected to my AS5304T leds definition.

Current AS66xx macthing rule

		// AS66
		.matches = {
			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "GeminiLake"),
		},
		.driver_data = &asustor_6700_driver_data,

My try of matching an AS5304T

		// AS5304 -- Not working properly
		.matches = {
			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "GeminiLake"),
			DMI_EXACT_MATCH(DMI_PRODUCT_UUID, "12345678-1234-5678-90ab-cddeefaabbcc"),
		},
		.driver_data = &asustor_5304_driver_data,

The overridden matching rule for making it work with an AS5304T

		// AS66
		.matches = {
			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "GeminiLake"),
		},
		.driver_data = &asustor_5304_driver_data,

Can anyone having access to an AS66xx device tell any non common string that could be usable for differentiating both models?
Or can anyone tell if my definition for leds is usable for the AS66xx models? If it is, then we can merge both detections, if not then we need more info to differentiate them both.

I have the leds code for the AS6302T and AS5304T published here: #37

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions