Skip to content

Possible incorrect variable usage #8

Open
@victorubieto

Description

@victorubieto

Hi,

I'm trying to implement a VDB parser for a personal engine without using the OpenVDB library because it is quite large and has many dependencies. I found your repository, which is easier to understand than the original, and I must say that I am very impressed with your work.

While looking at the BufferIteration class, I think I found a bug in your code. Specifically, when you call precision.size, I believe you meant precisionLUT.size. I have debugged it, and precision.size returns undefined, but it does not break the execution. I don't know if I am right or not, but I thought it was a good idea to let you know.

const mantissa = '1' + binary.slice(precisionLUT.exp + 1, precision.size);

Cheers,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions