First version of FxScreenGraph refactor #27187
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdotb-moz
added
the
Do Not Merge ⛔️
Generated by 🚫 Danger Swift against 0008262 |
lmarceau
reviewed
Jun 9, 2025
Comment on lines
+3
to
+4
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | ||
| import XCTest |
There was a problem hiding this comment.
nit, spacing
Suggested change
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | |
| import XCTest | |
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | |
| import XCTest |
| } | ||
| } | ||
|
|
||
| // swiftlint:disable all |
There was a problem hiding this comment.
Could we disable only the specific rules that were causing an issue here? I think this would be better than disabling all
| } | ||
| } | ||
|
|
||
| // swiftlint:enable all |
There was a problem hiding this comment.
There's no swiftlint:disable I think in this file, so this swiftlint enable doesn't seem necessary?
|
This pull request has conflicts when rebasing. Could you fix it @mdotb-moz? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
This PR implements the refactor of the FxScreenGraph, splitting the monolithic into several specific navigation files.
🎥 Demos
📝 Checklist
@Mergifyio backport release/v120)