Skip to content

refactor: Add common DTOs and schemas for the redesigned users list #16097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Jun 6, 2025

Summary

The new DTOs and schemas are part of the redesigned users list

Related Linear tickets, Github issues, and Community forum posts

PAY-2921

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/@n8n/api-types/src/index.ts 0.00% 2 Missing ⚠️
...tend/editor-ui/src/components/InviteUsersModal.vue 0.00% 2 Missing ⚠️
packages/@n8n/api-types/src/dto/index.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cstuncsik cstuncsik changed the title fix(editor): Cleanup ROLES and add types for new users list refactor: Add common DTOs and schemas for the new users list Jun 10, 2025
@cstuncsik cstuncsik marked this pull request as ready for review June 10, 2025 14:27
@cstuncsik cstuncsik requested a review from afitzek June 10, 2025 14:27
@cstuncsik cstuncsik changed the title refactor: Add common DTOs and schemas for the new users list refactor: Add common DTOs and schemas for the redesigned users list Jun 10, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 22 files and found no issues. Review PR in cubic.dev.

Copy link
Contributor

@afitzek afitzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we need to change the ROLE constant in this PR?

Ah nevermind, it just replaces the Role from the constant in the frontend.

afitzek
afitzek previously approved these changes Jun 11, 2025
Copy link
Contributor

@afitzek afitzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine, I would also remove the Role constant from the constants file in the editor-ui to avoid confusion and to make sure it is not used by anyone else. 👍

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik
Copy link
Contributor Author

I think this looks fine, I would also remove the Role constant from the constants file in the editor-ui to avoid confusion and to make sure it is not used by anyone else. 👍

Yes, thanks, I must have forgotten
Fixed

@cstuncsik cstuncsik requested a review from afitzek June 11, 2025 11:49
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit e681e6b into master Jun 11, 2025
33 checks passed
@cstuncsik cstuncsik deleted the pay-2921-add-common-dtos-and-schemas-for-the-new-users-list branch June 11, 2025 12:55
Copy link

cypress bot commented Jun 12, 2025

n8n    Run #11427

Run Properties:  status check passed Passed #11427  •  git commit e681e6b477: 🌳 master 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #11427
Run duration 04m 24s
Commit git commit e681e6b477: 🌳 master 🤖 PR User 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 505
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants