-
Notifications
You must be signed in to change notification settings - Fork 30.4k
refactor: Add common DTOs and schemas for the redesigned users list #16097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add common DTOs and schemas for the redesigned users list #16097
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
…-dtos-and-schemas-for-the-new-users-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 22 files and found no issues. Review PR in cubic.dev.
…-dtos-and-schemas-for-the-new-users-list
…-dtos-and-schemas-for-the-new-users-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we need to change the ROLE constant in this PR?
Ah nevermind, it just replaces the Role from the constant in the frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, I would also remove the Role constant from the constants file in the editor-ui to avoid confusion and to make sure it is not used by anyone else. 👍
✅ All Cypress E2E specs passed |
Yes, thanks, I must have forgotten |
✅ All Cypress E2E specs passed |
n8n
|
Project |
n8n
|
Branch Review |
master
|
Run status |
|
Run duration | 04m 24s |
Commit |
|
Committer | Csaba Tuncsik |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
10
|
|
0
|
|
505
|
View all changes introduced in this branch ↗︎ |
Summary
The new DTOs and schemas are part of the redesigned users list
Related Linear tickets, Github issues, and Community forum posts
PAY-2921
Review / Merge checklist
release/backport