feat (dashboard): support empty string as default text value in database tables #3112

dbm03 · 2025-01-01T16:50:34Z

User description

Resolves #2925

PR Type

Enhancement

Description

Add empty string default for text fields
Update UI to support new default value
Modify form handling for empty string defaults
Adjust column classification in record forms

Changes walkthrough 📝

Relevant files

Enhancement

BaseRecordForm.tsx `Update form handling for empty string defaults` dashboard/src/features/orgs/projects/database/dataGrid/components/BaseRecordForm/BaseRecordForm.tsx Updated column classification logic Modified insertable values handling Changed description for optional columns	+11/-3
ColumnEditorRow.tsx `Enhance DefaultValueAutocomplete for empty string` dashboard/src/features/orgs/projects/database/dataGrid/components/BaseTableForm/ColumnEditorRow.tsx Added formatting for empty string default value Updated DefaultValueAutocomplete component	+9/-2
DatabaseRecordInputGroup.tsx `Update DatabaseRecordInputGroup for empty defaults` dashboard/src/features/orgs/projects/database/dataGrid/components/DatabaseRecordInputGroup/DatabaseRecordInputGroup.tsx Updated getPlaceholder function for empty string Modified DatabaseRecordInputGroup component	+7/-0
postgresqlConstants.ts `Add empty string default to PostgreSQL functions` dashboard/src/features/orgs/projects/database/dataGrid/utils/postgresqlConstants/postgresqlConstants.ts Added ''::text to postgresFunctions for text type	+1/-1

Documentation

dry-kids-chew.md `Add changeset for empty string default feature` .changeset/dry-kids-chew.md Added changeset for new feature	+5/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

changeset-bot · 2025-01-01T16:50:38Z

🦋 Changeset detected

Latest commit: f539713

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nhost/dashboard	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-01-01T16:50:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dashboard-staging	✅ Ready (Inspect)	Visit Preview	Mar 17, 2025 10:55am
example-nextjs-server-components	✅ Ready (Inspect)	Visit Preview	Mar 17, 2025 10:55am
example-react-apollo	✅ Ready (Inspect)	Visit Preview	Mar 17, 2025 10:55am
example-sveltekit	✅ Ready (Inspect)	Visit Preview	Mar 17, 2025 10:55am
example-vue-apollo	✅ Ready (Inspect)	Visit Preview	Mar 17, 2025 10:55am

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
dashboard	⬜️ Ignored (Inspect)	Visit Preview	Mar 17, 2025 10:55am

github-actions · 2025-01-01T16:51:42Z

PR Reviewer Guide 🔍

(Review updated until commit `4f00d97`)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 2925 - Fully compliant Fully compliant requirements: Add option ''::text for Text default values Include ''::text as a default option for Text fields in the dropdown Allow non-nullable Text fields to have empty string as the default value
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Logic Complexity The changes in the condition for determining required columns and handling default values have increased the complexity of the code. This should be carefully reviewed to ensure it correctly handles all edge cases. if ( column.isPrimary \|\| (!column.isNullable && !column.defaultValue && !column.isDefaultValueCustom && !column.isIdentity) UI Behavior The new handling of empty string default values in the UI should be thoroughly tested to ensure it correctly displays and processes these values in all scenarios. const formattedInputValue = useMemo(() => { if (defaultValue?.value === '') { return "''::text"; } return isIdentity ? '' : inputValue; }, [isIdentity, defaultValue?.value, inputValue]);

github-actions · 2025-01-01T16:52:02Z

PR Code Suggestions ✨

Latest suggestions up to 4f00d97
Explore these optional code suggestions:

Category	Suggestion	Score
General	Extract complex condition into a separate function to improve code readability and maintainability Consider simplifying the condition for required columns by extracting it into a separate function. This will improve readability and make the code easier to maintain. dashboard/src/features/orgs/projects/database/dataGrid/components/BaseRecordForm/BaseRecordForm.tsx [45-51] -if ( - column.isPrimary \|\| - (!column.isNullable && - !column.defaultValue && - !column.isDefaultValueCustom && - !column.isIdentity) -) { +const isRequiredColumn = (column) => + column.isPrimary \|\| + (!column.isNullable && !column.defaultValue && !column.isDefaultValueCustom && !column.isIdentity); +if (isRequiredColumn(column)) { + Suggestion importance[1-10]: 6 Why: The suggestion improves code readability and maintainability by extracting a complex condition into a separate function. This change makes the code easier to understand and modify in the future.	6
General	Extract complex condition into a separate function to enhance code clarity and testability The condition for checking if a value should be included in insertableValues is complex and may be prone to errors. Consider extracting this logic into a separate function to improve readability and testability. dashboard/src/features/orgs/projects/database/dataGrid/components/BaseRecordForm/BaseRecordForm.tsx [102-107] -if ( - !value && - (gridColumn?.defaultValue \|\| - gridColumn?.defaultValue === '' \|\| - gridColumn?.isIdentity) -) { +const shouldUseDefaultValue = (value, gridColumn) => + !value && (gridColumn?.defaultValue !== undefined \|\| gridColumn?.isIdentity); +if (shouldUseDefaultValue(value, gridColumn)) { + Suggestion importance[1-10]: 6 Why: The suggestion enhances code clarity and testability by extracting a complex condition into a separate function. This improves readability and makes the logic easier to test independently.	6

Previous suggestions

Suggestions up to commit 021bc2f

Category	Suggestion	Score
General	Simplify the condition for checking default values and identity columns using modern JavaScript features Use optional chaining and nullish coalescing operators to simplify the condition for checking default values and identity columns. This will make the code more concise and easier to understand. dashboard/src/features/orgs/projects/database/dataGrid/components/BaseRecordForm/BaseRecordForm.tsx [102-107] -if ( - !value && - (gridColumn?.defaultValue \|\| - gridColumn?.defaultValue === '' \|\| - gridColumn?.isIdentity) -) { +if (!value && (gridColumn?.defaultValue !== undefined \|\| gridColumn?.isIdentity)) { Suggestion importance[1-10]: 8 Why: This suggestion effectively simplifies the condition using optional chaining and nullish coalescing, which aligns well with the PR's intent to handle empty string default values. It improves code readability and maintainability.	8
	Simplify the condition for determining required columns to improve readability and reduce potential errors Simplify the condition for determining required columns by using the logical OR operator (\|\|) instead of multiple AND (&&) operators. This will make the code more readable and less prone to errors. dashboard/src/features/orgs/projects/database/dataGrid/components/BaseRecordForm/BaseRecordForm.tsx [45-51] if ( column.isPrimary \|\| (!column.isNullable && - !column.defaultValue && - column.defaultValue !== '' && + (column.defaultValue === null \|\| column.defaultValue === undefined) && !column.isIdentity) ) { Suggestion importance[1-10]: 7 Why: The suggestion simplifies the complex condition, making it more readable and less error-prone. It correctly addresses the logic for determining required columns, which is a key part of the PR changes.	7
	Improve readability of string formatting using template literals Use a template literal for the formatted input value to improve readability and maintainability. This will make it easier to understand the logic for displaying empty string values. dashboard/src/features/orgs/projects/database/dataGrid/components/BaseTableForm/ColumnEditorRow.tsx [154-159] const formattedInputValue = useMemo(() => { if (defaultValue?.value === '') { - return "''::text"; + return `''::text`; } return isIdentity ? '' : inputValue; }, [isIdentity, defaultValue?.value, inputValue]); Suggestion importance[1-10]: 3 Why: While the suggestion to use template literals is valid, it offers only a minor improvement in readability. The existing code is already functional and clear, so the impact of this change is relatively low.	3

dbarrosop · 2025-01-02T08:27:01Z

I think there is a bug:

The automatically generated value thing shows for the wrong types and when there is no actual default value.

github-actions · 2025-01-17T20:00:45Z

Persistent review updated to latest commit 4f00d97

dbm03 requested a review from dbarrosop January 1, 2025 16:50

dbm03 self-assigned this Jan 1, 2025

dbm03 requested review from nunopato and onehassan as code owners January 1, 2025 16:50

vercel bot deployed to Preview – example-sveltekit January 1, 2025 16:50 View deployment

nhost-build added the dashboard Nhost Dashboard label Jan 1, 2025

github-actions bot added the Review effort [1-5]: 3 label Jan 1, 2025

vercel bot deployed to Preview – example-vue-apollo January 1, 2025 16:51 View deployment

vercel bot deployed to Preview – example-nextjs-server-components January 1, 2025 16:52 View deployment

vercel bot deployed to Preview – dashboard-staging January 1, 2025 16:59 View deployment

vercel bot deployed to Preview – example-vue-apollo January 1, 2025 17:00 View deployment

vercel bot deployed to Preview – example-react-apollo January 1, 2025 17:00 View deployment

vercel bot deployed to Preview – example-nextjs-server-components January 1, 2025 17:01 View deployment

vercel bot deployed to Preview – example-sveltekit January 1, 2025 17:03 View deployment

dbm03 marked this pull request as draft January 2, 2025 10:57

dbm03 force-pushed the feat/add-empty-string-default branch 2 times, most recently from df1332d to 4f00d97 Compare January 17, 2025 19:59

dbm03 marked this pull request as ready for review January 17, 2025 19:59

vercel bot deployed to Preview – example-nextjs-server-components January 17, 2025 20:01 View deployment

vercel bot deployed to Preview – dashboard-staging January 17, 2025 20:09 View deployment

vercel bot deployed to Preview – example-vue-apollo January 17, 2025 20:10 View deployment

vercel bot deployed to Preview – example-sveltekit January 17, 2025 20:11 View deployment

vercel bot deployed to Preview – example-react-apollo January 17, 2025 20:12 View deployment

vercel bot deployed to Preview – example-sveltekit January 21, 2025 00:40 View deployment

vercel bot deployed to Preview – example-react-apollo January 21, 2025 00:41 View deployment

vercel bot deployed to Preview – example-nextjs-server-components January 21, 2025 00:42 View deployment

vercel bot deployed to Preview – example-vue-apollo January 21, 2025 00:43 View deployment

vercel bot deployed to Preview – dashboard-staging January 21, 2025 00:47 View deployment

dbm03 marked this pull request as draft January 21, 2025 13:55

dbm03 force-pushed the feat/add-empty-string-default branch from 87daf1a to e3c41cd Compare January 29, 2025 23:35

vercel bot deployed to Preview – example-nextjs-server-components January 29, 2025 23:36 View deployment

vercel bot deployed to Preview – example-react-apollo January 29, 2025 23:37 View deployment

vercel bot deployed to Preview – dashboard-staging January 29, 2025 23:44 View deployment

vercel bot deployed to Preview – example-vue-apollo January 29, 2025 23:46 View deployment

vercel bot deployed to Preview – example-sveltekit January 29, 2025 23:47 View deployment

dbm03 added 6 commits March 16, 2025 23:46

feat: add empty string default in table creation

affe9db

feat: create rows with default empty string value

be9f6b6

chore: add changeset

7574504

chore: asd

3d917b6

fix: correct types when there is no actual default value

9b150c7

feat: add set to null edit button

f539713

dbm03 force-pushed the feat/add-empty-string-default branch from e3c41cd to f539713 Compare March 17, 2025 10:47

vercel bot deployed to Preview – example-react-apollo March 17, 2025 10:47 View deployment

vercel bot deployed to Preview – example-vue-apollo March 17, 2025 10:48 View deployment

vercel bot deployed to Preview – dashboard-staging March 17, 2025 10:54 View deployment

vercel bot deployed to Preview – example-sveltekit March 17, 2025 10:55 View deployment

vercel bot deployed to Preview – example-nextjs-server-components March 17, 2025 10:55 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat (dashboard): support empty string as default text value in database tables #3112

feat (dashboard): support empty string as default text value in database tables #3112

Uh oh!

dbm03 commented Jan 1, 2025 •

edited by github-actions bot

Loading

Uh oh!

changeset-bot bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

dbarrosop commented Jan 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

Uh oh!

feat (dashboard): support empty string as default text value in database tables #3112

Are you sure you want to change the base?

feat (dashboard): support empty string as default text value in database tables #3112

Uh oh!

Conversation

dbm03 commented Jan 1, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

PR Type

Description

Changes walkthrough 📝

Uh oh!

changeset-bot bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit 4f00d97)

Uh oh!

github-actions bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Previous suggestions

Uh oh!

dbarrosop commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

Uh oh!

dbm03 commented Jan 1, 2025 •

edited by github-actions bot

Loading

changeset-bot bot commented Jan 1, 2025 •

edited

Loading

vercel bot commented Jan 1, 2025 •

edited

Loading

github-actions bot commented Jan 1, 2025 •

edited

Loading

(Review updated until commit `4f00d97`)

github-actions bot commented Jan 1, 2025 •

edited

Loading

dbarrosop commented Jan 2, 2025 •

edited

Loading