Cache split infromation for TPE sampler. #6128
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6128 +/- ##
==========================================
+ Coverage 88.29% 88.43% +0.14%
==========================================
Files 207 207
Lines 14034 14051 +17
==========================================
+ Hits 12391 12426 +35
+ Misses 1643 1625 -18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a revival of #5464.
In the current implementation,
_split_cacheis unnecessarily repeated even when the results would be identical.This PR aims to eliminate such redundant computations and improve efficiency.
Description of the changes
The content is same as #5464 for now.
The cache uses
trial.numberas the key, and the value is the result of the split operation.