Skip to content

Cache split infromation for TPE sampler. #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fusawa-yugo
Copy link
Contributor

Motivation

This is a revival of #5464.
In the current implementation, _split_cache is unnecessarily repeated even when the results would be identical.
This PR aims to eliminate such redundant computations and improve efficiency.

Description of the changes

The content is same as #5464 for now.
The cache uses trial.number as the key, and the value is the result of the split operation.

@fusawa-yugo fusawa-yugo marked this pull request as draft June 4, 2025 09:50
@fusawa-yugo
Copy link
Contributor Author

I have a question.
Are there any issues with storing the cache in system_attrs of Study?
I feel that storing cache as an attribute of the Study would be more semantically appropriate.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (1fe6f76) to head (329dcdf).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6128      +/-   ##
==========================================
+ Coverage   88.29%   88.43%   +0.14%     
==========================================
  Files         207      207              
  Lines       14034    14051      +17     
==========================================
+ Hits        12391    12426      +35     
+ Misses       1643     1625      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant