Fix bug #81265: getimagesize returns 0 for 256px ICO images

Blacksmoke16 · nikic · commit 8f97f82e356f · 2021-07-16T10:05:58.000+02:00
Set ICO height/width to 256 if 0.
diff --git a/NEWS b/NEWS
@@ -10,6 +10,8 @@ PHP                                                                        NEWS
 
 - Standard:
   . Fixed bug #72146 (Integer overflow on substr_replace). (cmb)
+  . Fixed bug #81265 (getimagesize returns 0 for 256px ICO images).
+    (George Dietrich)
 
 29 Jul 2021, PHP 7.4.22
 
diff --git a/ext/standard/image.c b/ext/standard/image.c
@@ -1116,6 +1116,12 @@ static struct gfxinfo *php_handle_ico(php_stream * stream)
 		num_icons--;
 	}
 
+	if (0 == result->width)
+		result->width = 256;
+
+	if (0 == result->height)
+		result->height = 256;
+
 	return result;
 }
 /* }}} */
diff --git a/ext/standard/tests/image/32x256.ico b/ext/standard/tests/image/32x256.ico
diff --git a/ext/standard/tests/image/getimagesize_256_ico.phpt b/ext/standard/tests/image/getimagesize_256_ico.phpt
@@ -0,0 +1,26 @@
+--TEST--
+GetImageSize() for ico format with 256px height
+--FILE--
+<?php
+echo "*** Testing getimagesize() : 256px ico ***\n";
+var_dump(getimagesize(__DIR__ . "/32x256.ico"));
+
+?>
+===DONE===
+--EXPECT--
+*** Testing getimagesize() : 256px ico ***
+array(6) {
+  [0]=>
+  int(32)
+  [1]=>
+  int(256)
+  [2]=>
+  int(17)
+  [3]=>
+  string(23) "width="32" height="256""
+  ["bits"]=>
+  int(8)
+  ["mime"]=>
+  string(24) "image/vnd.microsoft.icon"
+}
+===DONE===

Original file line number	Diff line number	Diff line change
`@@ -1116,6 +1116,12 @@ static struct gfxinfo php_handle_ico(php_stream stream)`
`1116`	`1116`	`num_icons--;`
`1117`	`1117`	`}`
`1118`	`1118`
	`1119`	`+ if (0 == result->width)`
	`1120`	`+ result->width = 256;`
	`1121`	`+`
	`1122`	`+ if (0 == result->height)`
	`1123`	`+ result->height = 256;`
	`1124`	`+`
`1119`	`1125`	`return result;`
`1120`	`1126`	`}`
`1121`	`1127`	`/* }}} */`