Add cross-compiling 3rd argument to AC_RUN_IFELSE

petk · petk · commit bcab663f17f7 · 2023-12-22T16:12:59.000+01:00
Autotools emits warning if 3rd argument is empty. Call is wrapped in the
AC_CACHE_CHECK with php_cv_* cache variable name according to the docs.
diff --git a/configure.ac b/configure.ac
@@ -1586,15 +1586,16 @@ if test "$PHP_UNDEFINED_SANITIZER" = "yes"; then
     dnl cast to void*. In that case, set -fno-sanitize=function.
     OLD_CFLAGS="$CFLAGS"
     CFLAGS="$CFLAGS -fno-sanitize-recover=undefined"
+    AC_CACHE_CHECK([whether to add -fno-sanitize=function],[php_cv_ubsan_no_function],[
     AC_RUN_IFELSE([AC_LANG_SOURCE([[
 void foo(char *string) {}
 int main(void) {
   void (*f)(void *) = (void (*)(void *))foo;
   f("foo");
 }
-    ]])],,[ubsan_needs_no_function=yes],)
+    ]])],[php_cv_ubsan_no_function=no],[php_cv_ubsan_no_function=yes],[php_cv_ubsan_no_function=no])])
     CFLAGS="$OLD_CFLAGS"
-    if test "$ubsan_needs_no_function" = yes; then
+    if test "$php_cv_ubsan_no_function" = yes; then
       CFLAGS="$CFLAGS -fno-sanitize=function"
       CXXFLAGS="$CFLAGS -fno-sanitize=function"
     fi
