Closed
Description
Description
When building the current PHP-8.3 branch (tested with commit 99cd81c) in debug mode, PHP reports a memory leak when executing the following code:
<?php
trait MyTrait {
/**
* trait comment
*/
static $property;
}
class MyClass {
use MyTrait;
/**
* class comment
*/
static $property;
}Resulted in this output:
$ sapi/cli/php test.php
[Wed Sep 13 23:02:06 2023] Script: '/Users/florian/projects/php/php-src/test.php'
Zend/zend_string.h(174) : Freeing 0x0000000107c4d540 (64 bytes), script=/Users/florian/projects/php/php-src/test.php
=== Total 1 memory leaks detected ===
The doc block from the class is leaked. I had the same behavior with the 8.3 beta 3. The issue did not occur in 8.2 for me.
The following change fixes the issue for me:
diff --git a/Zend/zend_API.c b/Zend/zend_API.c
index d629b7166a..22ed008004 100644
--- a/Zend/zend_API.c
+++ b/Zend/zend_API.c
@@ -4332,6 +4332,9 @@ ZEND_API zend_property_info *zend_declare_typed_property(zend_class_entry *ce, z
(property_info_ptr->flags & ZEND_ACC_STATIC) != 0) {
property_info->offset = property_info_ptr->offset;
zval_ptr_dtor(&ce->default_static_members_table[property_info->offset]);
+ if (property_info_ptr->doc_comment) {
+ zend_string_release_ex(property_info_ptr->doc_comment, 0);
+ }
zend_hash_del(&ce->properties_info, name);
} else {
property_info->offset = ce->default_static_members_count++;But I don't think thats a proper fix for the issue.
PHP Version
PHP 8.3
Operating System
Mac OS X