Skip to content

random/standard: Correctly handle broken engines in php_array_pick_keys #13138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2024
Merged

random/standard: Correctly handle broken engines in php_array_pick_keys #13138

merged 2 commits into from
Jan 14, 2024

Conversation

TimWolla
Copy link
Member

No description provided.

@TimWolla TimWolla marked this pull request as draft January 13, 2024 13:46
@TimWolla
Copy link
Member Author

Found another unhandled failure case specifically for pickArrayKeys.

@TimWolla TimWolla force-pushed the random-pickArrayKeys-exception branch from d13cd79 to b60b8e5 Compare January 13, 2024 14:20
@TimWolla TimWolla marked this pull request as ready for review January 13, 2024 14:20
@TimWolla TimWolla force-pushed the random-pickArrayKeys-exception branch 2 times, most recently from fdb2b44 to 17e0c49 Compare January 13, 2024 14:26
nielsdos
nielsdos reviewed Jan 13, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change makes sense to me, just need to check why CI fails.

@TimWolla TimWolla force-pushed the random-pickArrayKeys-exception branch from 17e0c49 to b195e50 Compare January 13, 2024 15:25
@TimWolla TimWolla requested a review from nielsdos January 13, 2024 15:56
nielsdos
nielsdos approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Girgias
Girgias approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@TimWolla TimWolla merged commit 97c6da1 into php:PHP-8.2 Jan 14, 2024
@TimWolla TimWolla deleted the random-pickArrayKeys-exception branch January 14, 2024 12:01
TimWolla added a commit that referenced this pull request Jan 14, 2024
@TimWolla
Merge branch 'PHP-8.2' into PHP-8.3
f2f070a 
* PHP-8.2:
  random/standard: Correctly handle broken engines in php_array_pick_keys (#13138)
TimWolla added a commit that referenced this pull request Jan 14, 2024
@TimWolla
random/standard: Adjust #13138 for PHP 8.3
00ea756
TimWolla added a commit that referenced this pull request Jan 14, 2024
@TimWolla
Merge branch 'PHP-8.3'
0b7587f 
* PHP-8.3:
  random/standard: Adjust #13138 for PHP 8.3
  random/standard: Correctly handle broken engines in php_array_pick_keys (#13138)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 2, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
5c34475 
see php#13138 (comment)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 2, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
5c55ef5 
see php#13138 (comment)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 4, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
94af3d2 
see php#13138 (comment)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 6, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
d4ee93d 
see php#13138 (comment)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 25, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
09a7077 
see php#13138 (comment)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 25, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
88a8b10 
see php#13138 (comment)
TimWolla added a commit to TimWolla/php-src that referenced this pull request May 23, 2024
@TimWolla
random: Mark EG(exception) branches as UNEXPECTED
24f1367 
see php#13138 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Girgias approved these changes

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi is a code owner

Assignees
No one assigned
Labels
Extension: random Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @nielsdos @Girgias