Fixed #75220 - Segfault when calling is_callable on parent #2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 18, 2017
| @@ -3324,7 +3324,8 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zend_object *object, uint | |||
| ((fcc->function_handler->common.fn_flags & ZEND_ACC_CALL_VIA_TRAMPOLINE) || | |||
| fcc->function_handler->type == ZEND_OVERLOADED_FUNCTION_TEMPORARY || | |||
| fcc->function_handler->type == ZEND_OVERLOADED_FUNCTION)) { | |||
| if (fcc->function_handler->type != ZEND_OVERLOADED_FUNCTION) { | |||
| if (fcc->function_handler->type != ZEND_OVERLOADED_FUNCTION && | |||
| fcc->function_handler->common.function_name) { | |||
There was a problem hiding this comment.
Similar checks are repeated in a few more places. Maybe they also need to be changed?
There was a problem hiding this comment.
@nikic sounds reasonable, thanks. Just updated it.
andrewnester
force-pushed
the
75520-crash
branch
from
002f7cd to
f7e0321
Compare
|
@nikic any updates on it? |
|
Merged a680d70 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://bugs.php.net/bug.php?id=75220