Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: whipper-team/whipper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.0
Choose a base ref
...
head repository: whipper-team/whipper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.0
Choose a head ref
  • 19 commits
  • 49 files changed
  • 5 contributors

Commits on Oct 28, 2019

  1. Add missing dependency to Dockerfile

    Fixes #419.
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    484b2f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Merge branch 'master' into develop

    (To make versioning work properly for the develop branch, since
    currently the v0.8.0 tag only exists in the master branch. This merge
    will pull the v0.8.0 tagged commit into the develop branch too.)
    Freso committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    42638f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Add missing backslash to RegEX

    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    f740a0e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Add greetings action

    Remove configuration files of unused probot apps too.
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    af06718 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Initial pass on python 3 port

    Given the imminent end-of-life for Python 2, I didn't bother making the
    codebase compatible with both.
    
    Signed-off-by: Drew DeVault <[email protected]>
    ddevault authored and JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    64dd9d8 View commit details
    Browse the repository at this point in the history
  2. Address Freso's comment

    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b2d0664 View commit details
    Browse the repository at this point in the history
  3. accuraterip-checksum.c: Port to Python 3

    Accuraterip-checksum extension will be Python 3 only (JoeLametta).
    
    Co-authored-by: JoeLametta <[email protected]>
    Signed-off-by: Andreas Oberritter <[email protected]>
    Signed-off-by: JoeLametta <[email protected]>
    mtdcr and JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    8446c29 View commit details
    Browse the repository at this point in the history
  4. Address errors, improvements, formatting

    - Removed unused code not portable due to buffer() use
    - raw_input() does not exist in Python 3
    - Fixed octal constant syntax for Python 3
    - Fixed TypeError
    - Replace if not exists: makedirs(path) with single call: using makedirs(path, exist_ok=True)
    - Class inherits from object, can be safely removed from bases in python3: pylint's useless-object-inheritance (W0235) check
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    35201d5 View commit details
    Browse the repository at this point in the history
  5. Address test failures

    More details about the fix to the testDuration failure (regression):
    
    ```
    FAIL: testDuration (whipper.test.test_image_toc.CapitalMergeTestCase)
    testDuration
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/internet/defer.py", line 151, in maybeDeferred
        result = f(*args, **kw)
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/internet/utils.py", line 221, in runWithWarningsSuppressed
        reraise(exc_info[1], exc_info[2])
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/python/compat.py", line 464, in reraise
        raise exception.with_traceback(traceback)
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/internet/utils.py", line 217, in runWithWarningsSuppressed
        result = f(*a, **kw)
      File "/home/travis/build/whipper-team/whipper/whipper/test/test_image_toc.py", line 271, in testDuration
        self.assertEqual(self.table.getFrameLength(), 173530)
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/trial/_synctest.py", line 432, in assertEqual
        super(_Assertions, self).assertEqual(first, second, msg)
      File "/opt/python/3.5.6/lib/python3.5/unittest/case.py", line 829, in assertEqual
        assertion_func(first, second, msg=msg)
      File "/opt/python/3.5.6/lib/python3.5/unittest/case.py", line 822, in _baseAssertEqual
        raise self.failureException(msg)
    twisted.trial.unittest.FailTest: 184930 != 173530
    ```
    
    The test fails because if either nextTrack.session or thisTrack.session are None the if is false and the instructions inside it aren't executed. The check for None is needed because Python 3 doesn't allow NoneType comparisons (in Python 2 that was possible).
    IIRC correctly in that test nextTrack.session has value 2 while thisTrack.session is None. That means the Python 2 version evaluates the if condition to true, while the Python 3 version in the first commit does not.
    With this change both of the values of nextTrack.session and thisTrack.session are compared as int (if None, the value 1 is used for the comparison - as in disc session 1).
    
    Regression introduced in 64dd9d8.
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    fff3014 View commit details
    Browse the repository at this point in the history
  6. Address ResourceWarning warnings

    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    bb4c25d View commit details
    Browse the repository at this point in the history
  7. Port (misc) offsets script to Python 3

    I've also changed the output format a bit.
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    42019ce View commit details
    Browse the repository at this point in the history
  8. Update README, .travis.yml and Dockerfile for Python 3

    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    50c8cbb View commit details
    Browse the repository at this point in the history
  9. Merge pull request #411 from ddevault/py3

    Python 3 port
    
    From now on whipper's codebase will be compatible only with Python 3.
    NOTE: This pull request introduces a regression: more details in #424.
    
    Special thanks to @ddevault for kickstarting the porting effort!
    JoeLametta authored Nov 26, 2019
    Configuration menu
    Copy the full SHA
    d0efd74 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Reduce Docker image size

    - Removed useless apt cache from layer 3
    - Avoid installing apt recommended packages
    
    The compressed image now weights 67 MB less (≈ -30% size).
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    bbd28c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Fix regression introduced in Python 3 port

    Fixes #424.
    
    Signed-off-by: JoeLametta <[email protected]>
    MerlijnWajer authored and JoeLametta committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    47c62a9 View commit details
    Browse the repository at this point in the history
  2. Whipper's version RegEX: support all valid scheme cases

    Initial work by ArchangeGabriel: #421
    
    Fixes #420.
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Dec 3, 2019
    2 Configuration menu
    Copy the full SHA
    d5bf83e View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Fix offsets.py output

    Every line, except the last one, of the output was missing a double quote character at the end.
    
    Additional changes:
    - Specify parser to avoid BeautifulSoup warning
    - Use single quotes only
    
    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    bc31b98 View commit details
    Browse the repository at this point in the history
  2. Push whipper release v0.9.0

    Signed-off-by: JoeLametta <[email protected]>
    JoeLametta committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    c13f541 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'develop'

    JoeLametta committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    b1718a2 View commit details
    Browse the repository at this point in the history
Loading