-
Notifications
You must be signed in to change notification settings - Fork 95
Comparing changes
Open a pull request
base repository: whipper-team/whipper
base: v0.8.0
head repository: whipper-team/whipper
compare: v0.9.0
- 19 commits
- 49 files changed
- 5 contributors
Commits on Oct 28, 2019
-
Add missing dependency to Dockerfile
Fixes #419. Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 484b2f1 - Browse repository at this point
Copy the full SHA 484b2f1View commit details
Commits on Oct 31, 2019
-
Merge branch 'master' into develop
(To make versioning work properly for the develop branch, since currently the v0.8.0 tag only exists in the master branch. This merge will pull the v0.8.0 tagged commit into the develop branch too.)
Configuration menu - View commit details
-
Copy full SHA for 42638f6 - Browse repository at this point
Copy the full SHA 42638f6View commit details
Commits on Nov 1, 2019
-
Add missing backslash to RegEX
Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f740a0e - Browse repository at this point
Copy the full SHA f740a0eView commit details
Commits on Nov 14, 2019
-
Remove configuration files of unused probot apps too. Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for af06718 - Browse repository at this point
Copy the full SHA af06718View commit details
Commits on Nov 26, 2019
-
Given the imminent end-of-life for Python 2, I didn't bother making the codebase compatible with both. Signed-off-by: Drew DeVault <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64dd9d8 - Browse repository at this point
Copy the full SHA 64dd9d8View commit details -
Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b2d0664 - Browse repository at this point
Copy the full SHA b2d0664View commit details -
accuraterip-checksum.c: Port to Python 3
Accuraterip-checksum extension will be Python 3 only (JoeLametta). Co-authored-by: JoeLametta <[email protected]> Signed-off-by: Andreas Oberritter <[email protected]> Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8446c29 - Browse repository at this point
Copy the full SHA 8446c29View commit details -
Address errors, improvements, formatting
- Removed unused code not portable due to buffer() use - raw_input() does not exist in Python 3 - Fixed octal constant syntax for Python 3 - Fixed TypeError - Replace if not exists: makedirs(path) with single call: using makedirs(path, exist_ok=True) - Class inherits from object, can be safely removed from bases in python3: pylint's useless-object-inheritance (W0235) check Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 35201d5 - Browse repository at this point
Copy the full SHA 35201d5View commit details -
More details about the fix to the testDuration failure (regression): ``` FAIL: testDuration (whipper.test.test_image_toc.CapitalMergeTestCase) testDuration ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/internet/defer.py", line 151, in maybeDeferred result = f(*args, **kw) File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/internet/utils.py", line 221, in runWithWarningsSuppressed reraise(exc_info[1], exc_info[2]) File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/python/compat.py", line 464, in reraise raise exception.with_traceback(traceback) File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/internet/utils.py", line 217, in runWithWarningsSuppressed result = f(*a, **kw) File "/home/travis/build/whipper-team/whipper/whipper/test/test_image_toc.py", line 271, in testDuration self.assertEqual(self.table.getFrameLength(), 173530) File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/twisted/trial/_synctest.py", line 432, in assertEqual super(_Assertions, self).assertEqual(first, second, msg) File "/opt/python/3.5.6/lib/python3.5/unittest/case.py", line 829, in assertEqual assertion_func(first, second, msg=msg) File "/opt/python/3.5.6/lib/python3.5/unittest/case.py", line 822, in _baseAssertEqual raise self.failureException(msg) twisted.trial.unittest.FailTest: 184930 != 173530 ``` The test fails because if either nextTrack.session or thisTrack.session are None the if is false and the instructions inside it aren't executed. The check for None is needed because Python 3 doesn't allow NoneType comparisons (in Python 2 that was possible). IIRC correctly in that test nextTrack.session has value 2 while thisTrack.session is None. That means the Python 2 version evaluates the if condition to true, while the Python 3 version in the first commit does not. With this change both of the values of nextTrack.session and thisTrack.session are compared as int (if None, the value 1 is used for the comparison - as in disc session 1). Regression introduced in 64dd9d8. Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fff3014 - Browse repository at this point
Copy the full SHA fff3014View commit details -
Address ResourceWarning warnings
Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb4c25d - Browse repository at this point
Copy the full SHA bb4c25dView commit details -
Port (misc) offsets script to Python 3
I've also changed the output format a bit. Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42019ce - Browse repository at this point
Copy the full SHA 42019ceView commit details -
Update README, .travis.yml and Dockerfile for Python 3
Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 50c8cbb - Browse repository at this point
Copy the full SHA 50c8cbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0efd74 - Browse repository at this point
Copy the full SHA d0efd74View commit details
Commits on Nov 27, 2019
-
- Removed useless apt cache from layer 3 - Avoid installing apt recommended packages The compressed image now weights 67 MB less (≈ -30% size). Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bbd28c6 - Browse repository at this point
Copy the full SHA bbd28c6View commit details
Commits on Dec 3, 2019
-
Fix regression introduced in Python 3 port
Fixes #424. Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 47c62a9 - Browse repository at this point
Copy the full SHA 47c62a9View commit details -
Whipper's version RegEX: support all valid scheme cases
Initial work by ArchangeGabriel: #421 Fixes #420. Signed-off-by: JoeLametta <[email protected]>
2Configuration menu - View commit details
-
Copy full SHA for d5bf83e - Browse repository at this point
Copy the full SHA d5bf83eView commit details
Commits on Dec 4, 2019
-
Every line, except the last one, of the output was missing a double quote character at the end. Additional changes: - Specify parser to avoid BeautifulSoup warning - Use single quotes only Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc31b98 - Browse repository at this point
Copy the full SHA bc31b98View commit details -
Signed-off-by: JoeLametta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c13f541 - Browse repository at this point
Copy the full SHA c13f541View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1718a2 - Browse repository at this point
Copy the full SHA b1718a2View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.8.0...v0.9.0