Navigator should call didpop when popping page based route #170376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
chunhtai
commented
Jun 10, 2025
| @@ -5581,7 +5581,7 @@ class NavigatorState extends State<Navigator> with TickerProviderStateMixin, Res | |||
| if (entry.currentState.index <= _RouteLifecycle.idle.index) { | |||
| // The entry may have been disposed if the pop finishes synchronously. | |||
| assert(entry.route._popCompleter.isCompleted); | |||
| entry.currentState = _RouteLifecycle.popping; | |||
| entry.currentState = _RouteLifecycle.pop; | |||
There was a problem hiding this comment.
in flush history update, pop will notify observer and then transition to popping. I can't really find out why I made this change in the first place, but I think reverting this back to pop should be fine as long as no other error
There was a problem hiding this comment.
I agree here. Makes sense to me to keep it as pop.
justinmc
approved these changes
Jun 12, 2025
| @@ -5581,7 +5581,7 @@ class NavigatorState extends State<Navigator> with TickerProviderStateMixin, Res | |||
| if (entry.currentState.index <= _RouteLifecycle.idle.index) { | |||
| // The entry may have been disposed if the pop finishes synchronously. | |||
| assert(entry.route._popCompleter.isCompleted); | |||
| entry.currentState = _RouteLifecycle.popping; | |||
| entry.currentState = _RouteLifecycle.pop; | |||
There was a problem hiding this comment.
I agree here. Makes sense to me to keep it as pop.
chunhtai
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.