The Wayback Machine - https://web.archive.org/web/20220320195127/https://github.com/electron/windows-installer/pull/369
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update to Squirrel.Windows 2.0.1 #369

Merged
merged 5 commits into from Feb 18, 2021

Conversation

anaisbetts
Copy link
Contributor

@anaisbetts anaisbetts commented Nov 30, 2020

This is @dennisameling's great PR #361 but with the released Squirrel.Windows 2.0.1 binaries. :shipit:! See #354 for the details of what's new

@dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Dec 1, 2020

Can confirm this works as expected on Windows arm64 🚀 The installer itself I also created on an arm64 device thanks to the 7-Zip arm64 binaries from this PR.

Installers are created correctly:

image

The program is installed correctly as well:

image

@malept malept requested a review from Dec 2, 2020
@malept malept changed the title feat: Update to Squirrel.Windows 2.0.1 feat!: Update to Squirrel.Windows 2.0.1 Dec 2, 2020
Copy link
Member

@malept malept left a comment

This seems fine to me but I'd like @MarshallOfSound to take a look for a second opinion.

@malept malept requested a review from MarshallOfSound Dec 2, 2020
@anaisbetts
Copy link
Contributor Author

@anaisbetts anaisbetts commented Dec 2, 2020

@malept I think he had a look at the previous PR and 👍d it, this one has no changes other than the updated binaries

@tommyvct
Copy link

@tommyvct tommyvct commented Dec 14, 2020

Now it's been for 2 weeks, still nothing?

@dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Feb 11, 2021

Hi @MarshallOfSound, we'd be super grateful if you could review this PR. It's the final blocker for GitHub Desktop on ARM64: desktop/desktop#9691. Thanks in advance! 😊

@MarshallOfSound MarshallOfSound merged commit f03161f into electron:master Feb 18, 2021
5 of 6 checks passed
@electron-bot
Copy link

@electron-bot electron-bot commented Feb 18, 2021

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants