Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixes #9148: Use tuples for color specification #9149
Conversation
All checks have passed
jnothman
added this to the 0.19 milestone
Jun 17, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
jnothman
Jun 17, 2017
Owner
From the code it looks like the colours were previously arrays, not lists. Am I reading wrong?
|
From the code it looks like the colours were previously arrays, not lists. Am I reading wrong? |
|
@jnothman You're right, they're numpy arrays. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
|
LGTM |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Thanks. Are we sure this does not affect other examples? |
jnothman
merged commit 25917ba
into
scikit-learn:master
Jun 18, 2017
5 checks passed
ci/circleci
Your tests passed on CircleCI!
Details
codecov/patch
Coverage not affected when comparing 6ef8595...e3246e0
Details
codecov/project
96.29% remains the same compared to 6ef8595
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
|
The same issue could affect other examples--I can take a look. Should I close issue #9148 now that you've merged to master? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
jnothman
Jun 19, 2017
Owner
Yes. Ideally, you would say "Fixes #9148" in the pull request description
so github can close the issue automatically.
…On 19 June 2017 at 22:28, Nate Guerin ***@***.***> wrote:
The same issue could affect other examples--I can take a look.
Should I close issue #9148
<#9148> now that
you've merged to master?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#9149 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6w0xBvkQPdu8yWUXJ-mMjeTK9vLoks5sFmlUgaJpZM4N9Woa>
.
|
Yes. Ideally, you would say "Fixes #9148" in the pull request description
so github can close the issue automatically.
…On 19 June 2017 at 22:28, Nate Guerin ***@***.***> wrote:
The same issue could affect other examples--I can take a look.
Should I close issue #9148
<#9148> now that
you've merged to master?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#9149 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6w0xBvkQPdu8yWUXJ-mMjeTK9vLoks5sFmlUgaJpZM4N9Woa>
.
|
added a commit
that referenced
this pull request
Jun 19, 2017
gusennan
referenced this pull request
Jun 20, 2017
Closed
DBScan example errors with matplotlib 2.0.2 #9148
added a commit
to pewresearch/scikit-learn
that referenced
this pull request
Aug 2, 2017
added a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
added a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
added a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
added a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
added a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
added a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gusennan commentedJun 17, 2017
•
Edited 1 time
-
gusennan
Jun 18, 2017
This PR fixes the issue specified in #9148.
In the Matplotlib 'Specifying Colors' section, an array is not a valid color specification type. When this example is run using Python 3.5, and matplotlib 2.0.2 (latest), it errors with the message:
"ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()"
This change preserves the semantics of the example while allowing it to successfully run by converting the arrays to tuples for the matplotlib color specification.