Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
[MRG+1] Use almost minimal dependencies in Python 2 build on CircleCI #10627
Conversation
jotasi
added some commits
Jan 31, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
|
Failures |
All checks have passed
qinhanmin2014
approved these changes
Feb 13, 2018
LGTM, personally I might prefer a note in plot_gpc_xor.py to tell users this requires scipy>=0.14.
qinhanmin2014
changed the title from
[MRG] Use almost minimal dependencies in Python 2 build on CircleCI
to
[MRG+1] Use almost minimal dependencies in Python 2 build on CircleCI
Feb 13, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
lesteve
Feb 13, 2018
Member
Merging this one.
personally I might prefer a note in plot_gpc_xor.py to tell users this requires scipy>=0.14.
@qinhanmin2014 the fact that no one has reported the problem so far leads me to believe that the intersection of users using scipy <= 0.13.3 and the users running this example is very small. A PR adding a rst warning in the example would be more than welcome.
|
Merging this one.
@qinhanmin2014 the fact that no one has reported the problem so far leads me to believe that the intersection of users using scipy <= 0.13.3 and the users running this example is very small. A PR adding a rst warning in the example would be more than welcome. |
lesteve commentedFeb 12, 2018
This is a continuation of #10557 (that was reverted because examples/gaussian_process/plot_gpc_xor.py fails on scipy 0.13.3) so that we run the examples with versions that are as close as possible to the minimal required versions.