The Wayback Machine - https://web.archive.org/web/20250523102041/https://github.com/scikit-learn/scikit-learn/pull/10759
Skip to content

[MRG+1] DOC Fixed Broken Link in boston_housing_dataset.rst #10759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 6, 2018
Merged

[MRG+1] DOC Fixed Broken Link in boston_housing_dataset.rst #10759

merged 6 commits into from
Mar 6, 2018

Conversation

iArunava
Copy link
Contributor

@iArunava iArunava commented Mar 6, 2018

Fixed the link to the Boston Housing Dataset. Was unable to find the dataset in the UCI website (probably not there). But found them in the Index pages.

qinhanmin2014
qinhanmin2014 reviewed Mar 6, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the new url is acceptable but I would like to see if there's a better one (Or will the original url be OK shortly?).

@qinhanmin2014
Copy link
Member

Please also correct other places to complete the PR. Try something like

$ git grep 'archive.ics.uci.edu/ml/datasets/Housing'

@iArunava
Copy link
Contributor Author

iArunava commented Mar 6, 2018

Please also correct other places to complete the PR.

Yeah sure!

Hmm, the new url is acceptable but I would like to see if there's a better one (Or will the original url be OK shortly?).

Well, I don't know about the original link, seems like it should be valid. I skimmed through UCI but couldn't find any dataset that says 'Housing' or something related to the Boston Housing Dataset.
Else you can check this link, it points directly to the .data file.

http://archive.ics.uci.edu/ml/machine-learning-databases/housing/housing.data

@iArunava
Copy link
Contributor Author

iArunava commented Mar 6, 2018 •
edited
Loading

By the way, for the wine_data.rst file.

The dataset link points directly to the .data file. But the UCI link is valid here.
http://archive.ics.uci.edu/ml/datasets/Wine

Should I make a change to that?

@qinhanmin2014
Copy link
Member

(1) Please search through the whole repo (you also need to update doc/tutorial/basic/tutorial.rst).
(2) Let's keep the links in other places (It's often easy to reach consensus on small PR).
(3) Both http://archive.ics.uci.edu/ml/machine-learning-databases/housing/housing.data and http://archive.ics.uci.edu/ml/machine-learning-databases/housing/ LGTM from my side.
(4) Please avoid unrelated changes (recover the deleted blank link)

@iArunava
Copy link
Contributor Author

iArunava commented Mar 6, 2018

Please search through the whole repo (you also need to update doc/tutorial/basic/tutorial.rst).

Overlooked that, my bad.

I made the changes. Is the PR ok now ?

qinhanmin2014
qinhanmin2014 approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sklearn/datasets/descr/boston_house_prices.rst Outdated
@@ -50,4 +50,4 @@ problems.

- Belsley, Kuh & Welsch, 'Regression diagnostics: Identifying Influential Data and Sources of Collinearity', Wiley, 1980. 244-261.
- Quinlan,R. (1993). Combining Instance-Based and Model-Based Learning. In Proceedings on the Tenth International Conference of Machine Learning, 236-243, University of Massachusetts, Amherst. Morgan Kaufmann.
- many more! (see http://archive.ics.uci.edu/ml/datasets/Housing)
- many more! (see https://archive.ics.uci.edu/ml/machine-learning-databases/housing/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove directly? I can't find any more there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah its the only one there.
Should I remove line 53 completely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

@qinhanmin2014 qinhanmin2014 changed the title Fixed Broken Link in boston_housing_dataset.rst [MRG+1] DOC Fixed Broken Link in boston_housing_dataset.rst Mar 6, 2018
@jnothman jnothman merged commit 5335216 into scikit-learn:master Mar 6, 2018
@iArunava iArunava deleted the fix_housing_link branch March 7, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iArunava @qinhanmin2014 @jnothman