The Wayback Machine - https://web.archive.org/web/20201020110623/https://github.com/go-sql-driver/mysql/pull/517
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3 #517

Merged
merged 3 commits into from Dec 1, 2016
Merged

Release v1.3 #517

merged 3 commits into from Dec 1, 2016

Conversation

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Nov 16, 2016

  • Updated CHANGELOG
  • Removed most recent version from README as we changed to "rolling release" with v1.2
  • Removed build status as no breaking commits are allowed to be merged to the master branch anyway.
@julienschmidt julienschmidt added this to the v1.3 milestone Nov 16, 2016
@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented Nov 28, 2016

Please review #524, which is a release blocker.
I'd then like to update this PR and make the release later today!

@julienschmidt julienschmidt force-pushed the release-v1.3 branch from 2d3fcd2 to 9585138 Nov 29, 2016
@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented Nov 29, 2016

Rebased and CHANGELOG updated.
PTAL

@julienschmidt julienschmidt force-pushed the release-v1.3 branch from 9585138 to 1ca64ac Nov 30, 2016
@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented Nov 30, 2016

Updated once again.
There is really not much to review in this PR... 🙄

@julienschmidt julienschmidt force-pushed the release-v1.3 branch from 1ca64ac to 0537873 Nov 30, 2016
@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented Nov 30, 2016

Aaand it's Dec. 1 in my timezone now. Last try...
I'm going to change the repository settings again and merge this PR without a review if there is still no comment later

@julienschmidt julienschmidt merged commit a0583e0 into master Dec 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@julienschmidt julienschmidt deleted the release-v1.3 branch Dec 1, 2016
@arnehormann
Copy link
Member

@arnehormann arnehormann commented Dec 3, 2016

@julienschmidt Uuuuuuh, so sorry. Skimmed it, looked at your blocker PR, forgot it. And then it was very, very busy at work and I only read the notifications. Please mention me if this happens again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.