Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed imports for appengine/cloudsql #700
Conversation
appengine.go import path of appengine/cloudsql has changed to google.golang.org/appengine/cloudsql - Fixed.
As far as I understand, there were more changes in the appengine packages than just the import path. |
I don't use cloudsql or appengine however it builds and runs outside of appengine and cloudsql without any problems. I just needed it to build so I could use it in my own app. Here is a rerun of go test github.com\rrbrussell\mysql -v
|
Okay, I'm going to merge this then. Please immediately report back if this breaks something. |
Just a question: there is build tag ( |
I am not as familiar with the golang tool chain as I am with some of the other programming language tool chains I use. I am not sure which tool was throwing the error message out. The Issue was occurring during dependency vendoring. The build tag may not be checked due to a bug in govedor or in one of the other tools that supports vendoring dependencies. |
This LGTM. There were no changes to the cloudsql package with the import path change. |
* Fixed broken import for appengine/cloudsql appengine.go import path of appengine/cloudsql has changed to google.golang.org/appengine/cloudsql - Fixed. * Added my name to the AUTHORS
Description
Updated the import path for appengine\cloudsql in appengine.go
Checklist