The Wayback Machine - https://web.archive.org/web/20201020112354/https://github.com/go-sql-driver/mysql/pull/718
Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tls=true didn't work with host without port. #718

Merged
merged 1 commit into from Dec 4, 2017
Merged

Fix tls=true didn't work with host without port. #718

merged 1 commit into from Dec 4, 2017

Conversation

@methane
Copy link
Member

@methane methane commented Nov 30, 2017 •
edited

Fixes #717

Description

After #669, port can be omitted. But if tls=true is used, tls.ServerName is not filled.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@methane
Fix tls=true didn't work with host without port.
Loading status checks…
c5207bc 
Fixes #717
@methane methane force-pushed the methane:fix-717-tls-hostport branch from 04e90ad to c5207bc Nov 30, 2017
@julienschmidt
julienschmidt approved these changes Dec 4, 2017
View changes
@methane methane merged commit 9181e3a into go-sql-driver:master Dec 4, 2017
3 checks passed
3 checks passed
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 77.608%
Details
@methane methane deleted the methane:fix-717-tls-hostport branch Dec 4, 2017
@msabramo
Copy link

@msabramo msabramo commented Feb 6, 2018

Looks like this change has not made it into a release yet, since the last release was in 2016. Any plans to cut a release? (if not, I can pull from git, but I'd use an official release version if one is coming soon)
bLamarche413 pushed a commit to bLamarche413/mysql that referenced this pull request Mar 23, 2018
@methane Brigitte Lamarche
Fix tls=true didn't work with host without port (go-sql-driver#718)
6992fad 
Fixes go-sql-driver#717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@methane @msabramo @julienschmidt
You can’t perform that action at this time.