The Wayback Machine - https://web.archive.org/web/20201020112318/https://github.com/go-sql-driver/mysql/pull/783
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one line note about 0000-00-00 date/datetime #783

Merged
merged 1 commit into from May 26, 2018

Conversation

@methane
Copy link
Member

@methane methane commented Apr 18, 2018

Fixes #741

Signed-off-by: INADA Naoki [email protected]

Fixes #741

Signed-off-by: INADA Naoki <[email protected]>
@julienschmidt julienschmidt added this to the v1.4.0 milestone May 21, 2018
@julienschmidt julienschmidt merged commit 64db0f7 into go-sql-driver:master May 26, 2018
3 checks passed
3 checks passed
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.138%
Details
@dolmen
Copy link
Contributor

@dolmen dolmen commented Jun 15, 2018

The zero value of time.Time is in location UTC. What happens when the loc option is set to another timezone than UTC?
The documentation should clarify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.