COLLECTED BY

Organization: Archive Team

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

History is littered with hundreds of conflicts over the future of a community, group, location or business that were "resolved" when one of the parties stepped ahead and destroyed what was there. With the original point of contention destroyed, the debates would fall to the wayside. Archive Team believes that by duplicated condemned data, the conversation and debate can continue, as well as the richness and insight gained by keeping the materials. Our projects have ranged in size from a single volunteer downloading the data to a small-but-critical site, to over 100 volunteers stepping forward to acquire terabytes of user-created data to save for future generations.

The main site for Archive Team is at archiveteam.org and contains up to the date information on various projects, manifestos, plans and walkthroughs.

This collection contains the output of many Archive Team projects, both ongoing and completed. Thanks to the generous providing of disk space by the Internet Archive, multi-terabyte datasets can be made available, as well as in use by the Wayback Machine, providing a path back to lost websites and work.

Our collection has grown to the point of having sub-collections for the type of data we acquire. If you are seeking to browse the contents of these collections, the Wayback Machine is the best first stop. Otherwise, you are free to dig into the stacks to see what you may find.

The Archive Team Panic Downloads are full pulldowns of currently extant websites, meant to serve as emergency backups for needed sites that are in danger of closing, or which will be missed dearly if suddenly lost due to hard drive crashes or server failures.

Collection: Archive Team: The Github Hitrub

This collection is a set of Github repository archives from two major sets: A panic grab upon the acquisition by Microsoft, and a larger, ongoing set of Pretty Much Everything.

TIMESTAMPS

The Wayback Machine - https://web.archive.org/web/20201020112435/https://github.com/go-sql-driver/mysql/pull/690

go-sql-driver / mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NamedValueChecker for mysqlConn #690

Merged

julienschmidt merged 1 commit into go-sql-driver:master from pushrax:named-value-checker

Nov 16, 2017

Contributor

pushrax commented Oct 20, 2017 •

edited

Fixes #342

Calls to Exec for non-prepared statements with uint64 arguments having high-bits set are currently broken. The typical "uint64 values with high bit set are not supported" error is returned.

_, err := db.Exec("INSERT INTO test (id) VALUES (?)", uint64(0xffffffffffffffff))

Now that the NamedValueChecker interface is in Go, this can be solved by implementing it for mysqlConn. The implementation is based on defaultCheckNamedValue.

I also included changes from golang/go@d7c0de9

cc @shuhaowu @daniellaniyo @hkdsun @fw42

Contributor Author

pushrax commented Oct 20, 2017 •

edited

This breaks the build for Go 1.7 and earlier, so I moved the implementation into the go1.8 file.

pushrax force-pushed the pushrax:named-value-checker branch from 0ce6231 to 5e3001f

fw42 commented Oct 23, 2017

This breaks the build for Go 1.7 and earlier, so I moved the implementation into the go1.8 file.

I assume that means that your binary will only include the fix to this issue if you compile with a newer version of Go? Compiling it with older Go versions will give you an unfixed version (same as before)?

fw42 reviewed

  
      @@ -157,6 +157,16 @@ func (c converter) ConvertValue(v interface{}) (driver.Value, error) {
    
        		return int64(u64), nil

        	case reflect.Float32, reflect.Float64:

        		return rv.Float(), nil

        	case reflect.Bool:

fw42 Oct 23, 2017

The changes in this file affect all versions (not just 1.8). Can you explain what this does? In particular what does this do to 1.7 and lower?

fw42 Oct 23, 2017

Oh nvm I just saw that this is from golang/go@`d7c0de9`

fw42 approved these changes

fw42 left a comment

LGTM as far as I can tell 👍

Contributor Author

pushrax commented Oct 23, 2017

Compiling it with older Go versions will give you an unfixed version (same as before)?

Right, the API for making the fix possible is not available in older Go versions.

Member

julienschmidt commented Oct 27, 2017 •

edited

The general approach looks fine to me 👍 .
Bonus points, if you implement further tests (e.g. for string #623), as the NamedValueChecker is used also for other values than uint64 with high bit set.

julienschmidt added this to the v1.4 milestone

julienschmidt added the enhancement label

pushrax force-pushed the pushrax:named-value-checker branch 2 times, most recently from 8f556d3 to 4214b36

Contributor Author

pushrax commented Nov 9, 2017

@julienschmidt ping

julienschmidt approved these changes

Member

julienschmidt left a comment

Seems good.
I'd like to merge #623 first though. The author of that PR is responsive again.

Member

julienschmidt commented Nov 15, 2017

#623 is merged. This PR now needs a rebase on (or merge with) the current master.


          Implement NamedValueChecker for mysqlConn

e281d84

* Also add conversions for additional types in ConvertValue
  ref golang/go@d7c0de9

pushrax force-pushed the pushrax:named-value-checker branch from 4214b36 to e281d84

Contributor Author

pushrax commented Nov 16, 2017

Done.

julienschmidt merged commit 78d399c into go-sql-driver:master

3 checks passed

3 checks passed

WIP ready for review

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

coverage/coveralls Coverage increased (+0.3%) to 77.535%

Details

Member

julienschmidt commented Nov 16, 2017

Thanks for contributing!

busyfree mentioned this pull request

sql db connection not check the server whether closed the connection ,so it caused the tcp4 sockets has many can't identify protocol or TCP localhost:11335->localhost:6379 (WAIT_CLOSED) #707

Closed

randomjunk mentioned this pull request

Column Valuers broken since #690 #708

Closed

randomjunk added a commit to randomjunk/mysql that referenced this pull request


          Fix Valuers by returning driver.ErrSkip if couldn't convert type inte…

875d541

…rnally

Added a test that Valuer types are handled correctly. This test fails without the fix.

CheckNamedValue code was included recently and breaks existing applications:
go-sql-driver#690

Reported in:
go-sql-driver#708

randomjunk added a commit to randomjunk/mysql that referenced this pull request


          Fix Valuers by returning driver.ErrSkip if couldn't convert type inte…

57372b7

…rnally

Added a test that Valuer types are handled correctly. This test fails without the fix.

CheckNamedValue code was included recently and breaks existing applications:
go-sql-driver#690

Reported in:
go-sql-driver#708

randomjunk mentioned this pull request

Fix Valuers by returning driver.ErrSkip if couldn't convert type internally #709

Merged

4 of 4 tasks complete

yareid mentioned this pull request

ConvertValue() panics when given a nil pointer to a type that implements driver.Valuer with a value receiver #739

Closed

yareid mentioned this pull request

Use database/sql ConvertValue() except for uint64 with high bit set #746

Closed

4 of 5 tasks complete

yareid mentioned this pull request

Update ConvertValue() to match the database/sql/driver implementation except for uint64 #760

Merged

4 of 5 tasks complete

bLamarche413 pushed a commit to bLamarche413/mysql that referenced this pull request


          Implement NamedValueChecker for mysqlConn (go-sql-driver#690)

f9c6a2c

* Also add conversions for additional types in ConvertValue
  ref golang/go@d7c0de9

shuhaowu mentioned this pull request

Fixes panic due to Uint64 conversion in DMLEvent (RowData) Shopify/ghostferry#190

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.