The Wayback Machine - https://web.archive.org/web/20201020112253/https://github.com/go-sql-driver/mysql/pull/800
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty SHA2 password handling #800

Merged
merged 3 commits into from May 23, 2018
Merged

Fix empty SHA2 password handling #800

merged 3 commits into from May 23, 2018

Conversation

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented May 21, 2018

Fixes #799

@arvenil please verify

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
Fixes #799
@julienschmidt julienschmidt added the bug label May 21, 2018
@julienschmidt julienschmidt added this to the v1.4.0 milestone May 21, 2018
@julienschmidt julienschmidt changed the title [WIP] Fix empty SHA2 password handling Fix empty SHA2 password handling May 21, 2018
arvenil added a commit to arvenil/mysql-test that referenced this pull request May 21, 2018
@arvenil
Copy link
Contributor

@arvenil arvenil commented May 21, 2018

@julienschmidt julienschmidt requested a review from methane May 23, 2018
arvenil added a commit to percona/qan-agent that referenced this pull request May 23, 2018
@julienschmidt julienschmidt merged commit ceae19c into master May 23, 2018
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.1%) to 77.059%
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@julienschmidt julienschmidt deleted the empty_sha256 branch May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.