I want to colaborate.

Hey @jbogarthyde^^

Thanks, @AXEL1988!

That's great -- We just need to remove the comments, it looks like the code doesn't need to change at all. The only tricky part is finding them all - there seem to be a lot of them!

• The imported examples for guide pages are under angular/aio/content/examples/
• The ones for the API reference pages are under angular/packages/examples/

We've only noticed it in the API examples, I don't know if it occurs in the guide examples.

Hi all,
is this issue has a PR?
If not I would like to help.

Hi @Menuka5! That'd be great! I can help you with the process if you like. :)

@kapunahelewong Yes, please 😄
For clarification, I just need to remove // #enddocregion from all angular code or all todo comment which include docregion?

@Menuka5 I think the only comments to remove are:

// TODO(issue/24571): remove '!'

Take a look at #24571 to see a screenshot. The tricky part is finding all of them. I believe though, that they are only in the API docs, not the guide documentation.

I think you want to leave the docregions because without them things will break. @petebacondarwin can you confirm that I'm giving @Menuka5 the right direction?

I found over 100+ entries lines contains above line in the project.
I will remove them after you guys give confirmation 😃

Do NOT remove any ‘docregion’ or ‘enddocregion’ comments. Remove ONLY the ‘TODO’ comments.

Got it. Will send a pull request after around 1 hour.

I opened a pull request. Hopefully, I didn't violate your PR rules 😃

I left a comment on the PR.

@brandonroberts @kapunahelewong @jbogarthyde Can please answer the concern of @petebacondarwin In PR #31713

@Menuka5, we'll need to follow @petebacondarwin's guidance here. As far as how to refactor to fix the underlying code (that is, to do the "TODO"), we'd need engineering input unless you know how to refactor the code to fix it. The place I can help you most effectively is the process of getting the PR through review, git questions, pinging the right experts, etc. Please let me know your thoughts.

I don't understand the new requirement. I am a beginner to angular.
Can you elaborate more on how to fix this? An example would be nice.

@Menuka5 - I don't know if this is a beginner's task. We need to work out on a case-by-case basis how to remove the ! operator without the TS compiler complaining and without breaking the functioning of the code.

Some are fairly easy, such as this https://github.com/angular/angular/pull/31713/files#r305699323, where we simply provide an initializer.

- public easing !: string | null;
+ public easing: string | null = null;

But in each case you must think through the necessary change.

I agree that deciding whether the ! actually needs to be removed is not a beginners task.
The task should be to remove only the TODO comments, and only in doc examples.

I recommend closing the existing PR and starting over. Look only in the examples directories, and remove only those TODO comments that come between // #docregion and // #enddocregion comments.

• The imported examples for guide pages are under angular/aio/content/examples/
• The ones for the API reference pages are under angular/packages/examples/

To reduce the review burden (since the examples touch so many different areas, which need to be reviewed by different code-owners), it might be best to do a separate PR for each examples/_package-or-area_ subfolder.