The Wayback Machine - https://web.archive.org/web/20210826040255/https://github.com/scikit-learn/scikit-learn/pull/14710
Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX encode target for scoring when using early stopping in HistGradientBoostinClassifier #14710

Merged
merged 3 commits into from Aug 22, 2019
Merged

FIX encode target for scoring when using early stopping in HistGradientBoostinClassifier #14710

merged 3 commits into from Aug 22, 2019

Conversation

@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Aug 21, 2019

fixes #14709
glemaitre added 2 commits Aug 21, 2019
@glemaitre
FIX encode target for scoring when using early stopping in HistGradie…
a0f6fa6 
…ntBoostingClassifier
@glemaitre
add line
f49864d
@thomasjpfan
thomasjpfan reviewed Aug 21, 2019
View changes
sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py Outdated Show resolved Hide resolved
@NicolasHug
NicolasHug approved these changes Aug 21, 2019
View changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Thanks @glemaitre , minor comments but LGTM
sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py Outdated Show resolved Hide resolved
doc/whats_new/v0.22.rst Outdated Show resolved Hide resolved
sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py Outdated Show resolved Hide resolved
@glemaitre
reviews
1e5a5cf
@adrinjalali
adrinjalali approved these changes Aug 22, 2019
View changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Nice, thanks @glemaitre
@adrinjalali adrinjalali merged commit 947dffc into scikit-learn:master Aug 22, 2019
17 checks passed
17 checks passed
@lgtm-com
LGTM analysis: C/C++ No code changes detected
Details
@lgtm-com
LGTM analysis: JavaScript No code changes detected
Details
@lgtm-com
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
@codecov
codecov/patch 100% of diff hit (target 96.9%)
Details
@codecov
codecov/project 96.9% (+<.01%) compared to 4b6273b
Details
@azure-pipelines
scikit-learn.scikit-learn Build #20190822.10 succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux pylatest_conda_mkl_pandas) Linux pylatest_conda_mkl_pandas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan

@NicolasHug NicolasHug

@adrinjalali adrinjalali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

HistGradientBoostingClassifier does not work with string target when early stopping turned on
4 participants
@glemaitre @NicolasHug @adrinjalali @thomasjpfan