Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd documentation entry for watch store unsubscription on component #1050
Labels
Comments
|
@LinusBorg I would like to pick this up |
|
It could be nice to have this added in the doc I think. It has been awhile but do you want to work on with this @karanisverma? |
|
Hey @kiaking, sorry I would not be able to pick this up. |
|
@karanisverma OK! Thanks for checking |
anschwa
added a commit
to anschwa/vuex
that referenced
this issue
Sep 30, 2020
anschwa
added a commit
to anschwa/vuex
that referenced
this issue
Sep 30, 2020
|
I would also like to see this get added to the docs. I opened a PR here: #1838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this feature solve?
Actually there are no information regarding the necessity to "unsubscribe" store watch on component destroy.
It would be good to set a warning on the API documentation (https://vuex.vuejs.org/en/api.html) to let users know that without explicit unsubscription, the watch will be keep even after component destroy.
This issue has been reported here #599 and closed as a won't fix.
This problem cause memory leak and in most of the case errors extremely hard to debug.
What does the proposed API look like?
For a minimalist resolution
A warning quote in https://vuex.vuejs.org/en/api.html .
Nice to have
A new entry in menu to explain how to use
watch(and then the tips for the unsubscription).It could be great to give a better knowledge of this feature.