Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove the HttpClient panel in the Web Profiler #33311
Open
Comments
This was referenced Aug 23, 2019
|
To improve DX, what if we parse the headers in the response and detect the debug token link to display it. WDYT ? |
|
@Neirda24 that's indeed a good idea. |
|
i have a guzzle collector but I couldn't fit httpclient datacollector data into it. how much is it possible to change what this collector already does and how it collects data?
|
fabpot
added a commit
that referenced
this issue
Jan 22, 2020
…n the Web Profiler -> Http Client panel (cristagu) This PR was squashed before being merged into the 5.1-dev branch (closes #35391). Discussion ---------- [WebProfilerBundle][HttpClient] Added profiler links in the Web Profiler -> Http Client panel | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | [#33311](#33311) | License | MIT | Doc PR | - As per @Neirda24's idea in this [comment](#33311 (comment)), I parsed the response headers collected by the TraceableHttpClient and created profiler links in the HttpClient Web Profiler panel for all the requests having the 'X-Debug-Token' header.  Commits ------- 70e11f9 [WebProfilerBundle][HttpClient] Added profiler links in the Web Profiler -> Http Client panel
fabpot
added a commit
that referenced
this issue
Jan 22, 2020
…le (nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpClient] collect the body of responses when possible | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Part of #33311 | License | MIT | Doc PR | - This is missing one thing: the HTML part in the profiler.   Commits ------- 121f728 [HttpClient] collect the body of responses when possible
nicolas-grekas
added a commit
that referenced
this issue
Feb 3, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [WebProfiler] Improve HttpClient Panel | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | np <!-- please add some, will be required by reviewers --> | Fixed tickets | #33311 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | ? Wishlist from issue : - [x] the panel UI could be improved I suppose, e.g. a tooltip on hover in the toolbar - [ ] putting requests in the "Performance" tab would be great (all timings are already in the collected "info") - [ ] ~response bodies are not collected yet~ #33315 (comment) - [ ] when a transport error occurs, (ie the "error" info is populated) we should maybe have a better display too? - [x] add a copy-as-curl button next to each request **[EDIT 07 oct 19]** This PR contains : - Display a tooltip in Toolbar - Add a link only for GET Request in profiler panel  Commits ------- e2e6bd0 [WebProfiler] Improve HttpClient Panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #33015 introduces a profiler panel for the HttpClient component.
It was decided to merge it and improve it in nex iterations.
Here are the ideas that would be great to contribute, help wante:
response bodies are not collected yet#35407