Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesMAINT Fixes lgtm errors with C/C++ #14041
Conversation
This comment has been minimized.
This comment has been minimized.
|
This PR fails lgtm because master fails (strangely). From the same link, we can see that this branch succeeded to be build and be analyzed. |
jnothman
approved these changes
Jun 13, 2019
This comment has been minimized.
This comment has been minimized.
|
Let's try it. |
jnothman
merged commit 73caac2
into
scikit-learn:master
Jun 13, 2019
15 of 16 checks passed
LGTM analysis: C/C++
Analysis failed (could not build the base commit (abf7721))
Details
LGTM analysis: JavaScript
No new or fixed alerts
Details
LGTM analysis: Python
No new or fixed alerts
Details
ci/circleci: deploy
Your tests passed on CircleCI!
Details
ci/circleci: doc
Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
codecov/patch
Coverage not affected when comparing abf7721...ec39c8b
Details
codecov/project
96.81% remains the same compared to abf7721
Details
scikit-learn.scikit-learn
Build #20190607.7 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas)
Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas)
Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda)
Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35_32)
Windows py35_32 succeeded
Details
scikit-learn.scikit-learn (Windows py37_64)
Windows py37_64 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda)
macOS pylatest_conda succeeded
Details
Kiku-Reise
added a commit
to Kiku-Reise/scikit-learn
that referenced
this pull request
Jun 18, 2019
koenvandevelde
added a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
thomasjpfan commentedJun 7, 2019
•
edited
Reference Issues/PRs
Fixes #14025
What does this implement/fix? Explain your changes.
There is strange hash mismatch error that is happening when C++/C is being analyzed.