The Wayback Machine - https://web.archive.org/web/20200627234820/https://github.com/angular/angular/pull/34955
Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to node v12 #34955

Closed
wants to merge 3 commits into from
Closed

build: migrate to node v12 #34955

wants to merge 3 commits into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Jan 24, 2020

No description provided.

@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2020
@googlebot googlebot added the cla: yes label Jan 24, 2020
@josephperrott josephperrott changed the base branch from node-12 to master Jan 24, 2020
@josephperrott josephperrott force-pushed the josephperrott:node-12 branch 2 times, most recently from 0aa4216 to 3409028 Jan 24, 2020
@josephperrott josephperrott marked this pull request as ready for review Jan 24, 2020
@josephperrott josephperrott requested review from angular/dev-infra-framework as code owners Jan 24, 2020
@josephperrott josephperrott requested a review from IgorMinar Jan 24, 2020
@filipesilva
filipesilva approved these changes Jan 24, 2020
View changes
tools/public_api_guard/common/common.d.ts
@@ -3,10 +3,10 @@ export declare const APP_BASE_HREF: InjectionToken<string>;
export declare class AsyncPipe implements OnDestroy, PipeTransform {
constructor(_ref: ChangeDetectorRef);
ngOnDestroy(): void;
transform<T>(obj: null): null;

This comment has been minimized.

Sign in to view
Copy link
@filipesilva

filipesilva Jan 24, 2020

Member

Surprising that the goldens change from updating node.

This comment has been minimized.

Sign in to view
Copy link
@devversion

devversion Jan 24, 2020

Member

We had the same on angular/components in the past. It's because NodeJS v12 now provides a stable sorting algorithm for .sort. This will be used by ts-api-guardian for sorting the members.
@kyliau
kyliau approved these changes Jan 24, 2020
View changes
@IgorMinar
IgorMinar approved these changes Jan 24, 2020
View changes
Copy link
Member

IgorMinar left a comment

Lgtm

Merge-assistance: global approval
@devversion
devversion approved these changes Jan 24, 2020
View changes
@gkalpak
gkalpak requested changes Jan 25, 2020
View changes
Copy link
Member

gkalpak left a comment

Marking this as PR action: cleanup, because I left a couple of minor questions/suggestions (to give you a chance to see/respond to them before this is merged). 😇
Feel free to dismiss my review and re-mark as PR action: merge without addressing 😁
.circleci/config.yml Outdated
var_3: &cache_key v3-angular-node-10.16-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "packages/bazel/package.bzl" }}-{{ checksum "aio/yarn.lock" }}
var_4: &cache_key_fallback v3-angular-node-10.16-
var_3: &cache_key v3-angular-node-12.14.1-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "packages/bazel/package.bzl" }}-{{ checksum "aio/yarn.lock" }}
var_4: &cache_key_fallback v3-angular-node-12.14.1-

This comment has been minimized.

Sign in to view
Copy link
@gkalpak

gkalpak Jan 25, 2020

Member

Why not -12-14- (or maybe even 12), so we don't have to update the key so frequently?
(I doubt the dependencies will be affected between patch or minor releases.)

This comment has been minimized.

Sign in to view
Copy link
@josephperrott

josephperrott Jan 27, 2020

Author Member

Sure, We can just move to saying node-12
.circleci/config.yml Outdated
@@ -109,7 +109,7 @@ executors:
# - Node 12
# - yarn 1.17
# - Python 3 3.7.4
image: windows-server-2019-vs2019:201908-02
image: windows-server-2019-vs2019:stable

This comment has been minimized.

Sign in to view
Copy link
@gkalpak

gkalpak Jan 25, 2020

Member

Does this mean that we might get a different version on each run?

This comment has been minimized.

Sign in to view
Copy link
@IgorMinar

IgorMinar Jan 26, 2020

Member

oh uh.. great catch! someone from circleci tried to move us to this "branch" image that autoupdates and it failed due to some issues. we should say pinned!

This comment has been minimized.

Sign in to view
Copy link
@josephperrott

josephperrott Jan 27, 2020

Author Member

Moved it back, especially since we are going to set our version of node by installing it manually, we should be fine to stay pinned.
.circleci/windows-env.ps1 Outdated
@@ -38,9 +38,12 @@ openssl aes-256-cbc -d -in .circleci\gcp_token -md md5 -out "$env:APPDATA\gcloud
####################################################################################################
copy .circleci\bazel.windows.rc ${Env:USERPROFILE}\.bazelrc

####################################################################################################
# Install version of specific version of node.

This comment has been minimized.

Sign in to view
Copy link
@gkalpak

gkalpak Jan 25, 2020

Member
Suggested change
# Install version of specific version of node.
# Install specific version of node.
@josephperrott
build: migrate to [email protected]
Loading status checks…
832b07b
@josephperrott
build: update API Golden files after node 12 update
Loading status checks…
2f846f2
@josephperrott
fixup! build: migrate to [email protected]
Loading status checks…
2c8b9e5
@josephperrott josephperrott force-pushed the josephperrott:node-12 branch from 3409028 to 2c8b9e5 Jan 27, 2020
AndrewKushnir added a commit that referenced this pull request Jan 27, 2020
@josephperrott @AndrewKushnir
build: migrate to [email protected] (#34955)
323de9b 
PR Close #34955
AndrewKushnir added a commit that referenced this pull request Jan 27, 2020
@josephperrott @AndrewKushnir
build: update API Golden files after node 12 update (#34955)
Loading status checks…
efb17ae 
PR Close #34955
AndrewKushnir added a commit that referenced this pull request Jan 27, 2020
@josephperrott @AndrewKushnir
build: update API Golden files after node 12 update (#34955)
Loading status checks…
b3bd6ca 
PR Close #34955
gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 28, 2020
@gkalpak
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job
ea7626b 
In angular#34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.
gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 28, 2020
@gkalpak
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job
b923501 
In angular#34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.
gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 28, 2020
@gkalpak
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job
015f833 
In angular#34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).
Example failure: https://circleci.com/gh/angular/angular/602499

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.
gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 28, 2020
@gkalpak
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job
8ca86c5 
In angular#34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).
Example failure: https://circleci.com/gh/angular/angular/602499

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.
This was referenced Jan 28, 2020
Closed
Merged
AndrewKushnir added a commit that referenced this pull request Jan 28, 2020
@gkalpak @AndrewKushnir
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job (…
Loading status checks…
fd03709 
…#35004)

In #34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).
Example failure: https://circleci.com/gh/angular/angular/602499

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.

PR Close #35004
AndrewKushnir added a commit that referenced this pull request Jan 28, 2020
@gkalpak @AndrewKushnir
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job (…
Loading status checks…
98a6fb9 
…#35004)

In #34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).
Example failure: https://circleci.com/gh/angular/angular/602499

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.

PR Close #35004
sonukapoor added a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@josephperrott @sonukapoor
build: migrate to [email protected] (angular#34955)
13964e1 
PR Close angular#34955
sonukapoor added a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@josephperrott @sonukapoor
build: update API Golden files after node 12 update (angular#34955)
46936ac 
PR Close angular#34955
sonukapoor added a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@gkalpak @sonukapoor
ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job (…
3a5574b 
…angular#35004)

In angular#34955, we switched to Node.js v12 on master and 9.0.x. This causes
the `aio_monitoring_job` CI job (which checks out files from the stable
branch; currently 8.2.x) to start failing yarn's engines check (since
the 8.2.x branch expects Node.js version <11).
Example failure: https://circleci.com/gh/angular/angular/602499

Since the job is expected to run with files from both the stable and the
master branches (and since the version of Node.js is not important
here), this commit uses the `--ignore-engines` option to prevent
failures due to Node.js version mismatch.

NOTE:
Typically, the stable and master branch are on the same Node.js version,
because related PRs land on both master and the patch branch. One
exception is during RC periods, when the stable branch is different than
the patch branch. These periods are usually short, but in the case of
9.0.0 the period has lasted several months causing the CI environments
between master and the stable branch to get significantly out-of-sync.

PR Close angular#35004
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 27, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2020
@josephperrott josephperrott deleted the josephperrott:node-12 branch Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar

@gkalpak gkalpak

@kyliau kyliau

@filipesilva filipesilva

@devversion devversion

Assignees
No one assigned
Labels
PR action: merge PR action: merge-assistance PR target: master & patch cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@josephperrott @IgorMinar @kyliau @filipesilva @devversion @gkalpak @googlebot
You can’t perform that action at this time.