WIP: internal_faces option for axes3d voxels #9927
Draft
Conversation
Can only get 5 of the 6 faces, though...
| By default, only exposed faces of a voxel are rendered, | ||
| but you can force the rendering of all faces of the voxels | ||
| by setting this keyword argument to True. | ||
| .. versionadded:: 2.1 |
WeatherGod
Dec 4, 2017
Author
Member
whoops, should be 2.2, not 2.1.
whoops, should be 2.2, not 2.1.
|
closes #9745 |
| voxel_faces[i1].append(p2 + square_rot) | ||
| elif not filled[i1] and filled[i2]: | ||
| elif (internal_faces or not filled[i1]) and filled[i2]: | ||
| voxel_faces[i2].append(p2 + square_rot) |
eric-wieser
Dec 11, 2017
•
Contributor
I think this will fix your bug, since right now the if and else are mutually exclusive:
if internal_faces:
voxel_faces[i1].append(p2 + square_rot)
voxel_faces[i2].append(p2 + square_rot)
el<the existing if>
I think this will fix your bug, since right now the if and else are mutually exclusive:
if internal_faces:
voxel_faces[i1].append(p2 + square_rot)
voxel_faces[i2].append(p2 + square_rot)
el<the existing if>
|
Drawing both faces on every border is likely to lead to z-fighting, isn't it? Unless the faces are one-sided, in which case you'll be alright. |
|
Perhaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Can only get 5 of the 6 faces, though... Must have done something wrong.
PR Summary
PR Checklist