Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
fix: missing PRN in xlsx.mini #1908
Conversation
|
@SheetJSDev I have no written unit test in this changes, but I have tested the changes in my local application and the CSV works. Also, the existing unit test seems to pass when I run the test locally.
|
|
Poke @SheetJSDev again |
|
Hi @SheetJSDev @srijonsaha may I have an update or response for the PR? If there's anything missing from the PR, please let me know to improve. I'm waiting for this patch before I can use Thanks! |
|
@garrettluu can you take a peek? |
|
Code itself looks fine, but please squash your commits into 1 with |
- build: update mini script
|
Thanks @garrettluu for the response and review. I've squashed the commit. Look forward to the update |
|
Hi @garrettluu @SheetJSDev I've made the requested changes. Please confirm if this is fine. Look forward to the release! |
- build: update mini script
Issue
#1760
Description
Based on my investigation, it seems like the function
read_prnin the mini is missingPRNwhen it tries to read a string of CSV file.My proposed solution is to add the
PRNdeclaration as part of theminibuild, which exists in thebits/40_harb.js.