The Wayback Machine - https://web.archive.org/web/20201220220244/https://github.com/lodash/lodash/pull/4027
Skip to content

/ lodash

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add minus example to ceil function #4027

Merged
merged 1 commit into from Oct 28, 2018
Merged

add minus example to ceil function #4027

merged 1 commit into from Oct 28, 2018

Conversation

@alireza-mh
Copy link
Contributor

@alireza-mh alireza-mh commented Oct 27, 2018

Add minus integer number to ceil function.
@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Oct 27, 2018 •
edited

CLA assistant check
All committers have signed the CLA.
@jdalton
Copy link
Member

@jdalton jdalton commented Oct 27, 2018

Hi @alireza-mh!

Instead of an additional value example would you mind tweaking this to describe ceil as a similar to Math.ceil. That way it provides more context for usage.
@alireza-mh alireza-mh force-pushed the alireza-mh:add-ceil-example branch from 9474d29 to 5ad1c96 Oct 27, 2018
@alireza-mh
Copy link
Contributor Author

@alireza-mh alireza-mh commented Oct 27, 2018 •
edited

Hi @jdalton,
i updated the PR.
by adding that example i was intended to avoid some mathematical errors.
i added round up definition by borrowing it from MDN web doc.
@alireza-mh
add round up description on ceil documentation
Unverified
The key that signed this is expired.
GPG key ID: 8B2A0B09992CB91E Learn about signing commits
Loading status checks…
c1caebc 
Signed-off-by: Alireza <[email protected]>
@alireza-mh alireza-mh force-pushed the alireza-mh:add-ceil-example branch from 5ad1c96 to c1caebc Oct 27, 2018
@jdalton jdalton merged commit d9c5082 into lodash:master Oct 28, 2018
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
@jdalton
Copy link
Member

@jdalton jdalton commented Oct 28, 2018

Thank you @alireza-mh!
@lock
Copy link

@lock lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@alireza-mh alireza-mh deleted the alireza-mh:add-ceil-example branch Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@alireza-mh @jsf-clabot @jdalton
You can’t perform that action at this time.