Ensure escapeRegExp returns an empty string when passing falsy values #4432
Conversation
escapeRegExp.js
Outdated
| @@ -22,7 +22,7 @@ const reHasRegExpChar = RegExp(reRegExpChar.source) | |||
| function escapeRegExp(string) { | |||
| return (string && reHasRegExpChar.test(string)) | |||
| ? string.replace(reRegExpChar, '\\$&') | |||
| : string | |||
| : string || '' | |||
jdalton
Aug 22, 2019
Member
can you wrap string || '' in parens please.
can you wrap string || '' in parens please.
blikblum
Aug 22, 2019
Author
Contributor
can you wrap string || '' in parens please.
Done
can you wrap string || '' in parens please.
Done
|
Rock! Thank you @blikblum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix test passing falsy values