The Wayback Machine - https://web.archive.org/web/20201220215813/https://github.com/lodash/lodash/pull/4623
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle leading zeros in quote html entity #4623

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

@gwwar
Copy link
Contributor

@gwwar gwwar commented Jan 8, 2020

HTML entities may have leading zeros, so in this case #39 #039 both refer to the same character '

We noticed this while fixing this issue WordPress/gutenberg#19187

I ran into trouble building and running tests locally, so I'm happy to follow up if there are more detailed instructions elsewhere for running this locally.

Testing Instructions

  • Verify that tests still pass
  • No other regressions
@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Jan 8, 2020

CLA assistant check
All committers have signed the CLA.

@falsyvalues falsyvalues merged commit 588bf3e into lodash:master Feb 5, 2020
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
@falsyvalues
Copy link
Member

@falsyvalues falsyvalues commented Feb 5, 2020

Thank You @gwwar!

@jdalton I think we can backport this to 4.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.