The Wayback Machine - https://web.archive.org/web/20210824065708/https://github.com/scikit-learn/scikit-learn/pull/18121
Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Fixes TheilSenRegressor with fit_intercept=False and one feature #18121

Merged
merged 3 commits into from Oct 9, 2020
Merged

FIX Fixes TheilSenRegressor with fit_intercept=False and one feature #18121

merged 3 commits into from Oct 9, 2020

Conversation

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Aug 7, 2020

Reference Issues/PRs

Fixes #18104

What does this implement/fix? Explain your changes.

_spatial_median now returns a ndarray when there was only one feature.
@thomasjpfan
FIX Fixes TheilSenRegressor with fit_intercept=False and one feature
fed2e35
@thomasjpfan
DOC Adds whats new
15906e3
@glemaitre
glemaitre approved these changes Aug 20, 2020
View changes
Copy link
Contributor

@glemaitre glemaitre left a comment

LGTM
@glemaitre glemaitre added this to TO BE MERGED in Guillaume's pet Aug 24, 2020
@lorentzenchr
lorentzenchr approved these changes Oct 8, 2020
View changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

LGTM. Needs to merge master before ready to merge.
@thomasjpfan
Merge remote-tracking branch 'upstream/master' into theil_san_fix
1ee3d80
@lorentzenchr lorentzenchr merged commit 06c710a into scikit-learn:master Oct 9, 2020
22 checks passed
22 checks passed
@github-actions
triage
Details
@lgtm-com
LGTM analysis: C/C++ No code changes detected
Details
@lgtm-com
LGTM analysis: JavaScript No code changes detected
Details
@lgtm-com
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
@circleci-artifacts-redirector
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
@codecov
codecov/patch 100.00% of diff hit (target 98.17%)
Details
@codecov
codecov/project 98.17% (+0.00%) compared to 7dcb1ac
Details
@azure-pipelines
scikit-learn.scikit-learn Build #20201009.18 succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux py36_conda_openblas) Linux py36_conda_openblas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux py36_ubuntu_atlas) Linux py36_ubuntu_atlas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit) Linux32 py36_ubuntu_atlas_32bit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit) Windows py36_pip_openblas_32bit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp) macOS pylatest_conda_mkl_no_openmp succeeded
Details
@thomasjpfan thomasjpfan mentioned this pull request Oct 13, 2020
Closed
amrcode added a commit to amrcode/scikit-learn that referenced this pull request Oct 19, 2020
@thomasjpfan @amrcode
FIX Fixes TheilSenRegressor with fit_intercept=False and one feature (s…
17f3a77 
…cikit-learn#18121)
jayzed82 added a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@thomasjpfan @jayzed82
FIX Fixes TheilSenRegressor with fit_intercept=False and one feature (s…
2de88b2 
…cikit-learn#18121)
@glemaitre glemaitre moved this from TO BE MERGED to MERGED in Guillaume's pet Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre

@lorentzenchr lorentzenchr

Assignees
No one assigned
Labels
module:linear_model
Projects
Guillaume's pet
MERGED
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

sklearn TheilSenRegressor ValueError when setting fit_intercept=False for 1d regressors
3 participants
@thomasjpfan @glemaitre @lorentzenchr