Add xarray copyright notice to comply with reuse under Apache License #35213
Conversation
|
sure |
jreback
merged commit 280efbf
into
pandas-dev:master
12 of 13 checks passed
12 of 13 checks passed
k-fillmore
pushed a commit
to k-fillmore/pandas
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In xarray-contrib/pint-xarray#11, @keewis and I noticed that pandas's (pandas'?...possessive forms are weird) reuse with modification of xarray code added in eee83e2 did not include xarray's copyright notice as required by the Apache License, Version 2.0 (which is not included in the license text itself, unlike MIT or BSD). I'm not sure how big of a deal this is, but given that pint-xarray is going ahead and modeling its code citation practice after that of pandas, I wanted to see what the thoughts are here on it. This PR takes a simple fix and just adds the copyright notice to top of the
LICENSES/XARRAY_LICENSEfile.Also, I'm not sure if this requires a whatsnew entry or not.
closes #xxxxtests added / passedpassesblack pandaspassesgit diff upstream/master -u -- "*.py" | flake8 --diff