Thank you for the PR @adriangb. You need not update the pbtxt files afaik. It's enough to add those strings in losses.py file against the function.

Ah makes sense, will do!

Just pushed the change @pavithrasv, please take a look when you have a chance. Thanks.

I assume the test failures due to API change are expected and just require manual approval/override?

@adriangb Can you please address Ubuntu Sanity errors? Thanks!

I think I see what happened. Can you re-approve @gbaned ?

@adriangb Still, Ubuntu Sanity errors appearing, Can you fix those?. Thanks!

I see that I left duplicate decorator, I think that was the problem this time. I rebased to the last commit in master and re-applied the decorator (a single time). For some reason ci_sanity.sh is building the container but not running for me so... do you mind approving again @gbaned ? Thanks

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

The change adds a symbol to the API and therefore needs to be reviewed by API owners. More details: https://github.com/tensorflow/community/blob/master/governance/api-reviews.md

The change adds a symbol to the API and therefore needs to be reviewed by API owners. More details: https://github.com/tensorflow/community/blob/master/governance/api-reviews.md

Could you at least tag the API owners? The link in the doc you linked is currently broken (https://github.com/orgs/tensorflow/teams/api-owners). @pavithrasv already okayed this PR.

The change adds a symbol to the API and therefore needs to be reviewed by API owners. More details: https://github.com/tensorflow/community/blob/master/governance/api-reviews.md

Could you at least tag the API owners? The link in the doc you linked is currently broken (https://github.com/orgs/tensorflow/teams/api-owners). @pavithrasv already okayed this PR.

Forgot to mention that I did add "API review" tag.

Btw, I'm running bazel to update the goldens but even with --jobs=1 and inside a fresh tensorflow/tensorflow:devel container I'm getting unrelated compilation errors and it takes ages. I wish there was a way to make changes in TF that didn't require compiling a bunch of unrelated C++ APIs. If there is, please do share!

Let me import this locally and try doing the goldens internally.

Let me import this locally and try doing the goldens internally.

Thank you! I gave you access to my fork in case you want to just push there.

Let me import this locally and try doing the goldens internally.

Thank you! I gave you access to my fork in case you want to just push there.

Thanks for giving access to the fork. I'll work on the imported change since that is slightly faster, but if the changed failed to import I would have used the fork