The Wayback Machine - https://web.archive.org/web/20201018152525/https://github.com/SheetJS/js-adler32/pull/4
Skip to content

/ js-adler32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored CLI to separate npm package #4

Merged
merged 1 commit into from Jun 27, 2020
Merged

Refactored CLI to separate npm package #4

merged 1 commit into from Jun 27, 2020

Conversation

@garrettluu
Copy link
Contributor

@garrettluu garrettluu commented Jun 25, 2020

Addresses this issue.

Moved CLI into its own package, located in packages/adler32-cli. Published NPM package here
@garrettluu
Refactored CLI to separate npm package
Loading status checks…
b40011c 
* Moved CLI to packages folder

* Fixed mistake in path

* Bumped version

* Fixed dependency issues

* Version bump
@coveralls
Copy link

@coveralls coveralls commented Jun 25, 2020

Coverage Status

Coverage remained the same at 88.71% when pulling b40011c on garrettluu:master into d747eda on SheetJS:master.
@reviewher reviewher requested a review from srijonsaha Jun 26, 2020
@garrettluu garrettluu mentioned this pull request Jun 27, 2020
Open
@SheetJSDev SheetJSDev merged commit b40011c into SheetJS:master Jun 27, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.71%
Details
security/snyk (SheetJSDev) 1 security test has passed
Details
@stof
Copy link

@stof stof commented Jul 16, 2020

this misses the removal of the exit-on-epipe and printj dependencies from the adler32 package (as they are only used by the CLI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srijonsaha srijonsaha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@garrettluu @coveralls @stof @SheetJSDev
You can’t perform that action at this time.