The Wayback Machine - https://web.archive.org/web/20201105162511/https://github.com/dinerojs/dinero.js/issues/41
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm scripts - OS compatibility #41

Open
frobinsonj opened this issue Dec 17, 2018 · 1 comment · May be fixed by #172
Open

npm scripts - OS compatibility #41

frobinsonj opened this issue Dec 17, 2018 · 1 comment · May be fixed by #172

Comments

@frobinsonj
Copy link
Contributor

@frobinsonj frobinsonj commented Dec 17, 2018

Hi, I have recently started using Dinero and I am interested in potentially contributing where I can. However, I have encountered some issues trying to run the build and docs scripts. This is due me being on Windows (no rm command, backslashes in paths, etc).

These are easy fixes so I have no problems getting on, I would just like to suggest editing these scripts to allow for compatibility across operating systems.

rm -rf can be replaced with something like del-cli but I am unsure how to adjust paths to work for all. Maybe something like run-script-os would be a good solution if you're interested in this suggestion.

Thanks :)

@sarahdayan
Copy link
Collaborator

@sarahdayan sarahdayan commented Dec 28, 2018

Hi @frobinsonj, I'm definitely interested in making it easier for more users to play with and potentially contribute to this project. Feel free to open a PR if you want to tackle it sooner than I can.

nguyenj added a commit to nguyenj/dinero.js that referenced this issue Aug 18, 2020
…cripts

Resolves dinerojs#41
nguyenj added a commit to nguyenj/dinero.js that referenced this issue Aug 18, 2020
…cripts

Resolves dinerojs#41
@nguyenj nguyenj linked a pull request that will close this issue Aug 18, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.