The Wayback Machine - https://web.archive.org/web/20200810041349/https://github.com/TheAlgorithms/Javascript/pull/183
Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Domain Name Extractor #183

Open
wants to merge 4 commits into
base: master
from
Open

Add Domain Name Extractor #183

wants to merge 4 commits into from

Conversation

@arfbacem
Copy link

arfbacem commented May 25, 2020 •
edited

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
arfbacem added 4 commits May 25, 2020
@arfbacem
Add Hex to Base64 conversion
Loading status checks…
b1fd9db
@arfbacem
Add Roman To Decimal and Decimal To Roman Conversion
Loading status checks…
2582f39
@arfbacem
Add Words To Sentence Algo
Loading status checks…
90ce7b0
@arfbacem
Add Domain Name Extractor
Loading status checks…
96bbea6
@lgtm-com
Copy link

lgtm-com bot commented May 25, 2020

This pull request introduces 1 alert when merging 96bbea6 into 3a7df56 - view on LGTM.com

new alerts:

  • 1 for Syntax error
@ruppysuppy
ruppysuppy suggested changes Jun 19, 2020
View changes
Copy link
Contributor

ruppysuppy left a comment

Please go through the logs and implement the changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy

Assignees
No one assigned
Labels
failing npm standards
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@arfbacem @ruppysuppy @itsvinayak
You can’t perform that action at this time.