The Wayback Machine - https://web.archive.org/web/20200810041254/https://github.com/TheAlgorithms/Javascript/pull/243
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OddEvenSort Added #243

Open
wants to merge 1 commit into
base: master
from

Conversation

@MustafaSalih1993
Copy link

MustafaSalih1993 commented Aug 3, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@nandanvasudevan
Copy link
Contributor

nandanvasudevan commented Aug 3, 2020

Test your code

This works.

// > const test = [5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2]
// > const result = [ 1, 2, 2, 2, 3, 5, 5, 6, 7, 8, 12, 14 ]
// > oddEvenSort(test)
// > (test.every((val, index) => val === result[index]))
// true

Output

(node:6784) ExperimentalWarning: The ESM module loader is experimental.
running doctests in test.js...
[ 5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2 ]
[ 1, 2, 2, 2, 3, 5, 5, 6, 7, 8, 12, 14 ]
.

Weird DocTest behaviour

Can anyone explain why the below doctest passes? Documentation for JavaScript seems poor.
Notice the 399 in the middle.

// > const test = [5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2]
// > oddEvenSort(test)
// test [1,2,2,2,399,5,5,6,7,8,12,14]

The output I get:

(node:6277) ExperimentalWarning: The ESM module loader is experimental.
running doctests in test.js...
[ 5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2 ]
[ 1, 2, 2, 2, 3, 5, 5, 6, 7, 8, 12, 14 ]
.

I think it's evaluating with test. Is there a syntax I am missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.