The Wayback Machine - https://web.archive.org/web/20210927101113/https://github.com/nestjs/nest/pull/4806
Skip to content

/ nest Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move from grpc to @grpc/grpc-js #4806

Merged
merged 2 commits into from Jan 27, 2021
Merged

feat: move from grpc to @grpc/grpc-js #4806

merged 2 commits into from Jan 27, 2021

Conversation

@gperdomor
Copy link
Contributor

@gperdomor gperdomor commented May 15, 2020 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4799

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

a new package should be installed: @grpc/grpc-js

Other information
@tonivj5
Copy link

@tonivj5 tonivj5 commented May 15, 2020 •
edited

Update package.json too (here and here)

@gperdomor gperdomor changed the title feat: move from grpc to @grpc/grpc-js WIP: feat: move from grpc to @grpc/grpc-js May 15, 2020
@gperdomor gperdomor force-pushed the feature/grpc-js branch 3 times, most recently from 1bcaf2a to 4889cd5 May 15, 2020
@gperdomor
Copy link
Contributor Author

@gperdomor gperdomor commented May 15, 2020

@tonivj5 I have problems with tests... can you help me?

@tonivj5
Copy link

@tonivj5 tonivj5 commented May 15, 2020

I don't know what happens and Circle CI logs aren't public, I can't check it either... Wait the reply of some maintainer, it will come! 😉

@kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented May 23, 2020

image

It seems that you didn't mock the listen() method in the unit tests

@LastKing LastKing mentioned this pull request Jun 17, 2020
Closed
3 tasks
@LastKing LastKing mentioned this pull request Jun 17, 2020
Merged
1 task
@coveralls
Copy link

@coveralls coveralls commented Jun 18, 2020 •
edited

Pull Request Test Coverage Report for Build 208e1d5f-fc96-4c3f-95c9-1c6986ba55dd

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.801%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-grpc.ts 7 8 87.5%
Totals Coverage Status
Change from base Build 508ee9cb-667a-4578-94ba-4cef112fd1ba: -0.02%
Covered Lines: 4923
Relevant Lines: 5193
💛 - Coveralls

@gperdomor gperdomor force-pushed the feature/grpc-js branch 2 times, most recently from b8d0f67 to 6a2ba31 Jun 18, 2020
@gperdomor gperdomor changed the title WIP: feat: move from grpc to @grpc/grpc-js feat: move from grpc to @grpc/grpc-js Jun 18, 2020
@gperdomor
Copy link
Contributor Author

@gperdomor gperdomor commented Jun 18, 2020

thanks to @LastKing for solving tests issues... please @kamilmysliwiec review this when you have some time 🙏

@gperdomor
feat: move from grpc to @grpc/grpc-js
a66a183 
build: update package dependencies

fix: use bindAsync in server-grpc

test(): server gprc port already listen error

test(): remove surplus commit

feat: fix packages

# Conflicts:
#	package-lock.json
#	package.json
#	sample/04-grpc/package-lock.json
#	sample/04-grpc/package.json
@gperdomor gperdomor force-pushed the feature/grpc-js branch from 6a2ba31 to a66a183 Jul 2, 2020
@gperdomor
feat: force circle ci run
1e0852f
@gperdomor
Copy link
Contributor Author

@gperdomor gperdomor commented Jul 2, 2020

any particular reason why this PR is blocked?

@kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Jul 2, 2020

This PR introduces a breaking change. It won't be merged till the next major release.

@kamilmysliwiec kamilmysliwiec added this to the 8.0.0 milestone Jan 13, 2021
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jan 27, 2021
Closed
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 8.0.0 Jan 27, 2021
@kamilmysliwiec kamilmysliwiec merged commit 036a9fb into nestjs:8.0.0 Jan 27, 2021
10 checks passed
@renovate renovate bot mentioned this pull request Jul 9, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 10, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 10, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 10, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 11, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 11, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 12, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 12, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 12, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 15, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 15, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 15, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 17, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 17, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 19, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 19, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 19, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 19, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 19, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 20, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 24, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 26, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 27, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 27, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 27, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 28, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 31, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Aug 2, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Aug 3, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Aug 3, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies scope: microservices status: blocked 🚫
Projects
None yet
Milestone
8.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@gperdomor @tonivj5 @kamilmysliwiec @coveralls